chore(docs): refine JSDoc wording for experimental BindingMagicString#8639
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 11, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds TypeDoc/JSDoc documentation to the native Rust-backed MagicString binding so the public RolldownMagicString export is marked and described as experimental in generated API docs.
Changes:
- Add a JSDoc block describing the native MagicString implementation.
- Mark the binding-backed constructor export as
@experimental. - Clarify that it is exported publicly as
RolldownMagicString.
binding-magic-string7fdef10 to
9b656b2
Compare
hyf0
approved these changes
Mar 11, 2026
hyf0
approved these changes
Mar 11, 2026
hyf0
reviewed
Mar 11, 2026
Contributor
Member
Author
Merge activity
|
9b656b2 to
7e1ef16
Compare
shulaoda
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from #8626 (comment)