Skip to content

feat: suggest entriesAware in bundle analyzer optimization tips #8502

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-01-feat_add_suggestion_when_some_module_are_not_reachable_for_specific_entry
Mar 1, 2026
Merged

feat: suggest entriesAware in bundle analyzer optimization tips #8502
graphite-app[bot] merged 1 commit intomainfrom
03-01-feat_add_suggestion_when_some_module_are_not_reachable_for_specific_entry

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Mar 1, 2026 •
edited
Loading

Suggest entriesAware when common chunks contain modules that are not reachable from all entries that import the chunk.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Mar 1, 2026
Merged
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Mar 1, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Mar 1, 2026
Merged
Merged
@IWANABETHATGUY IWANABETHATGUY changed the title feat: add suggestion when some module are not reachable for specific entry feat: suggest entriesAware in bundle analyzer optimization tips Mar 1, 2026
IWANABETHATGUY
IWANABETHATGUY commented Mar 1, 2026
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review March 1, 2026 08:00
@graphite-app graphite-app bot changed the base branch from 02-07-feat_markdown_format_chunk_meta to graphite-base/8502 March 1, 2026 08:01
@IWANABETHATGUY IWANABETHATGUY requested review from hyf0 and shulaoda March 1, 2026 08:07
@graphite-app graphite-app bot force-pushed the 03-01-feat_add_suggestion_when_some_module_are_not_reachable_for_specific_entry branch from c4aa58b to 38ef71c Compare March 1, 2026 08:13
@graphite-app graphite-app bot changed the base branch from graphite-base/8502 to main March 1, 2026 08:14
@graphite-app graphite-app bot force-pushed the 03-01-feat_add_suggestion_when_some_module_are_not_reachable_for_specific_entry branch from 38ef71c to cb8a5a4 Compare March 1, 2026 08:14
@netlify
Copy link

netlify bot commented Mar 1, 2026 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit bc1eff2
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69a3f85879eb9500086190ae

@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 1, 2026 •
edited
Loading

Merge activity

@IWANABETHATGUY
feat: suggest entriesAware in bundle analyzer optimization tips
bc1eff2 
 (#8502)

Suggest `entriesAware` when common chunks contain modules only reachable from specific entries.
@graphite-app graphite-app bot force-pushed the 03-01-feat_add_suggestion_when_some_module_are_not_reachable_for_specific_entry branch from cb8a5a4 to bc1eff2 Compare March 1, 2026 08:27
@graphite-app graphite-app bot merged commit bc1eff2 into main Mar 1, 2026
36 checks passed
@graphite-app graphite-app bot deleted the 03-01-feat_add_suggestion_when_some_module_are_not_reachable_for_specific_entry branch March 1, 2026 08:37
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2026

Benchmarks Rust

  • target: main(7c89e51)
  • pr: 03-01-feat_add_suggestion_when_some_module_are_not_reachable_for_specific_entry(bc1eff2)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     83.3±2.63ms        ? ?/sec    1.00     80.7±3.33ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.04     93.5±3.15ms        ? ?/sec    1.00     90.2±2.14ms        ? ?/sec
bundle/bundle@rome_ts                                        1.04    165.4±6.06ms        ? ?/sec    1.00    158.6±6.50ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.04    186.7±5.90ms        ? ?/sec    1.00    180.3±4.66ms        ? ?/sec
bundle/bundle@threejs                                        1.17     76.0±3.86ms        ? ?/sec    1.00     65.1±1.75ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.07     80.9±1.76ms        ? ?/sec    1.00     75.4±1.87ms        ? ?/sec
bundle/bundle@threejs10x                                     1.03   797.7±24.58ms        ? ?/sec    1.00    773.1±6.79ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01   898.3±23.88ms        ? ?/sec    1.00    887.9±7.10ms        ? ?/sec
scan/scan@rome_ts                                            1.00     78.9±1.80ms        ? ?/sec    1.00     78.8±1.83ms        ? ?/sec
scan/scan@threejs                                            1.04     29.0±1.71ms        ? ?/sec    1.00     28.0±0.54ms        ? ?/sec
scan/scan@threejs10x                                         1.01    276.5±6.79ms        ? ?/sec    1.00    273.7±4.13ms        ? ?/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

@shulaoda shulaoda Awaiting requested review from shulaoda

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0