Skip to content

chore: remove useless async-scoped#840

Merged
hyf0 merged 1 commit intomainfrom
chore/remove-async-scoped
Apr 12, 2024
Merged

chore: remove useless async-scoped#840
hyf0 merged 1 commit intomainfrom
chore/remove-async-scoped

Conversation

@Brooooooklyn
Copy link
Member

Description

block_on_spawn_all and async-scope is useless

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Brooooooklyn and the rest of your teammates on Graphite Graphite

@netlify
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6c14ae5
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6618bef8138ef0000811ddb7

@hyf0 hyf0 enabled auto-merge (squash) April 12, 2024 04:58
@codecov
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 80.47%. Comparing base (9a51f98) to head (6c14ae5).

Files Patch % Lines
crates/rolldown/src/stages/scan_stage.rs 88.23% 2 Missing ⚠️
crates/rolldown/src/utils/render_chunks.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   80.53%   80.47%   -0.07%     
==========================================
  Files         133      132       -1     
  Lines        6699     6657      -42     
==========================================
- Hits         5395     5357      -38     
+ Misses       1304     1300       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyf0 hyf0 merged commit ba6b79d into main Apr 12, 2024
@hyf0 hyf0 deleted the chore/remove-async-scoped branch April 12, 2024 05:01
@codspeed-hq
Copy link

codspeed-hq bot commented Apr 12, 2024

CodSpeed Performance Report

Merging #840 will not alter performance

Comparing chore/remove-async-scoped (6c14ae5) with main (9a51f98)

Summary

✅ 6 untouched benchmarks

@hyf0 hyf0 mentioned this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants