feat: emit warning for circular dependency#839
Merged
hyf0 merged 4 commits intoApr 12, 2024
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
requested changes
Apr 12, 2024
| @@ -97,7 +98,27 @@ impl<'a> LinkStage<'a> { | |||
| if !circular_dependencies.is_empty() { | |||
| let mut cycles = circular_dependencies.into_iter().collect::<Vec<_>>(); | |||
| cycles.sort(); | |||
Member
There was a problem hiding this comment.
remove this sort call. moduleid is not stable.
| self.warnings.extend(cycles.iter().map(|path| { | ||
| let module_names: Vec<String> = path | ||
| .iter() | ||
| .map(|id| match id { |
| ModuleId::Normal(id) => self | ||
| .module_table | ||
| .normal_modules | ||
| .get(*id) |
hyf0
requested changes
Apr 12, 2024
| .map_or_else(|| "Unknown external module".to_string(), |module| module.name.clone()), | ||
| ModuleId::Normal(id) => self.module_table.normal_modules.get(*id).map_or_else( | ||
| || "Unknown normal module".to_string(), | ||
| |module| module.pretty_path.clone(), |
| } | ||
|
|
||
| fn message(&self) -> String { | ||
| format!("Circular dependency: {}.", self.paths.join(" -> ")) |
CodSpeed Performance ReportMerging #839 will not alter performanceComparing Summary
|
251e608 to
1bc0c51
Compare
Member
|
Need to something with logging. Let's me take this PR from here. You could leave it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
emit warning for circular dependency
for #831