Skip to content

feat(rust): collect circular dependencies while sorting modules#830

Merged
hyf0 merged 1 commit into
mainfrom
04-11-feat_rust_collect_circular_dependencies_while_sorting_modules
Apr 11, 2024
Merged

feat(rust): collect circular dependencies while sorting modules#830
hyf0 merged 1 commit into
mainfrom
04-11-feat_rust_collect_circular_dependencies_while_sorting_modules

Conversation

@hyf0

@hyf0 hyf0 commented Apr 11, 2024

Copy link
Copy Markdown
Member

Description

This PR do what #398 did without extra traverse.

hyf0 commented Apr 11, 2024

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify

netlify Bot commented Apr 11, 2024

Copy link
Copy Markdown

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 0d7a28d
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6617a355ca8fe60008f08ca2

@codecov

codecov Bot commented Apr 11, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 80.56%. Comparing base (f5aab3a) to head (0d7a28d).

Files Patch % Lines
...tes/rolldown/src/stages/link_stage/sort_modules.rs 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #830      +/-   ##
==========================================
+ Coverage   80.50%   80.56%   +0.05%     
==========================================
  Files         133      133              
  Lines        6664     6693      +29     
==========================================
+ Hits         5365     5392      +27     
- Misses       1299     1301       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyf0 hyf0 merged commit c092e0b into main Apr 11, 2024
@hyf0 hyf0 deleted the 04-11-feat_rust_collect_circular_dependencies_while_sorting_modules branch April 11, 2024 08:51
@codspeed-hq

codspeed-hq Bot commented Apr 11, 2024

Copy link
Copy Markdown

CodSpeed Performance Report

Merging #830 will not alter performance

Comparing 04-11-feat_rust_collect_circular_dependencies_while_sorting_modules (0d7a28d) with main (f5aab3a)

Summary

✅ 6 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant