refactor: remove EXPORT_UNDEFINED_VARIABLE error#8228
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 9, 2026
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
Copilot
AI
changed the title
[WIP] Remove EXPORT_UNDEFINED_VARIABLE error due to Oxc semantic coverage
Remove EXPORT_UNDEFINED_VARIABLE error (covered by Oxc semantic)
Feb 7, 2026
sapphi-red
reviewed
Feb 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes Rolldown’s custom EXPORT_UNDEFINED_VARIABLE diagnostic now that Oxc semantic analysis reports undefined exports as PARSE_ERROR, eliminating duplicated error handling in Rolldown.
Changes:
- Removed
ExportUndefinedVariableErrorfromEventKindand the generatedEventKindSwitcher. - Deleted the
export_undefined_variablediagnostic event and itsBuildDiagnosticconstructor. - Updated
AstScannerto stop emitting a custom diagnostic forexport { foo }whenfoois not a local binding (letting Oxc surface the error instead).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| crates/rolldown_error/src/types/event_kind.rs | Drops the ExportUndefinedVariableError event kind and its string mapping. |
| crates/rolldown_error/src/generated/event_kind_switcher.rs | Regenerates bitflags to remove the deleted event kind flag. |
| crates/rolldown_error/src/build_diagnostic/events/mod.rs | Removes the module export for the deleted diagnostic event implementation. |
| crates/rolldown_error/src/build_diagnostic/events/export_undefined_variable.rs | Deletes the dedicated diagnostic event implementation. |
| crates/rolldown_error/src/build_diagnostic/constructors.rs | Removes the BuildDiagnostic::export_undefined_variable constructor and import. |
| crates/rolldown/src/ast_scanner/mod.rs | Stops pushing the custom undefined-export diagnostic when a local binding can’t be found. |
Contributor
Benchmarks Rust |
IWANABETHATGUY
approved these changes
Feb 7, 2026
Member
Merge activity
|
Oxc's semantic analysis now detects and reports undefined exports as `PARSE_ERROR`, making Rolldown's custom `EXPORT_UNDEFINED_VARIABLE` error redundant. ## Changes - Removed `ExportUndefinedVariableError` variant from `EventKind` enum - Deleted `export_undefined_variable.rs` event implementation - Removed error constructor from `BuildDiagnostic` - Updated `ast_scanner/mod.rs` to skip adding exports for undefined bindings (Oxc reports the error) - Regenerated `event_kind_switcher.rs` via code generator ## Verification The existing test `export_undefined_variable` now receives the error from Oxc: ``` [PARSE_ERROR] Error: Export 'bar' is not defined ╭─[ main.js:4:3 ] │ 4 │ bar │ ─┬─ ``` Previously, Rolldown detected this after parsing; now Oxc catches it during semantic analysis. <!-- START COPILOT CODING AGENT SUFFIX --> <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > Remove `EXPORT_UNDEFINED_VARIABLE` error as it is covered by Oxc semntic </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
75314d2 to
5790e65
Compare
This was referenced Feb 11, 2026
Closed
Merged
shulaoda
added a commit
that referenced
this pull request
Feb 11, 2026
## [1.0.0-rc.4] - 2026-02-11 💡 Granular `comments` Option - New `output.comments` option provides fine-grained control over comment preservation - The `output.legalComments` option is now deprecated and use `comments.legal` instead ### 🚀 Features - rename error name to `RolldownError` from `RollupError` (#8262) by @sapphi-red - add hidden `resolve_tsconfig` function for Vite (#8257) by @sapphi-red - rust: introduce `rolldown_watcher` (#8161) by @hyf0 - unify `comments` and `legalComments` into a single granular `comments` option (#8229) by @IWANABETHATGUY - add builtin plugin for visualizing chunk graph (#8162) by @IWANABETHATGUY - show import declaration location in AssignToImport errors (#8222) by @Copilot - show import declaration span in CannotCallNamespace error (#8223) by @Copilot - emit error when plugin accidentally removes runtime module symbols (#8203) by @IWANABETHATGUY - support tsconfig loading & inputMap for `transform` (#8180) by @sapphi-red - rolldown_plugin_vite_reporter: update warning message to link to Rolldown docs (#8205) by @sapphi-red ### 🐛 Bug Fixes - avoid panic on untranspiled JSX syntax by reporting a diagnostic error (#8226) by @IWANABETHATGUY - rolldown_plugin_vite_import_glob: relax absolute path check and improve invalid glob warning (#8219) by @shulaoda - merge chunks after detect circular reference (#8154) by @IWANABETHATGUY - rust: detect runtime module side effects based on its content (#8209) by @hyf0 ### 🚜 Refactor - rename `other` to `jsdoc` in comments options (#8256) by @IWANABETHATGUY - rename chunk-visualize plugin with bundle-analyzer plugin (#8255) by @IWANABETHATGUY - remove EXPORT_UNDEFINED_VARIABLE error (#8228) by @Copilot - consolidate missing runtime symbol errors into a single diagnostic (#8220) by @IWANABETHATGUY - stabilize `parse` and `parseSync` (#8215) by @sapphi-red - return errors instead of panicking on builtin plugin conversion failure (#8217) by @shulaoda - expose `parse` / `minify` / `transform` from `rolldown/utils` (#8214) by @sapphi-red - prepare defer chunk merging (#8153) by @IWANABETHATGUY ### 📚 Documentation - remove `<script>` escape behavior difference note from `platform` option (#8253) by @sapphi-red - TypeScript & JSX support by plugins (#8183) by @sapphi-red ### 🧪 Testing - ensure runtime module is preserved even if it's not used but has side effects (#8213) by @hyf0 ### ⚙️ Miscellaneous Tasks - deps: update oxc to v0.113.0 (#8267) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.12.0 (#8272) by @renovate[bot] - deps: update oxc apps (#8269) by @renovate[bot] - deps: update test262 submodule for tests (#8261) by @sapphi-red - deps: update crate-ci/typos action to v1.43.4 (#8260) by @renovate[bot] - deps: update dependency esbuild to v0.27.3 (#8250) by @renovate[bot] - deps: update rust crates (#8244) by @renovate[bot] - deps: update dependency semver to v7.7.4 (#8247) by @renovate[bot] - deps: update github-actions (#8243) by @renovate[bot] - deps: update npm packages (#8245) by @renovate[bot] - deps: update oxc resolver to v11.17.1 (#8240) by @renovate[bot] - deps: update rust crate oxc_sourcemap to v6.0.2 (#8241) by @renovate[bot] - rust: handle ignored `RUSTSEC-2025-0141` cargo check error (#8235) by @hyf0 - deps: update dependency oxlint-tsgolint to v0.11.5 (#8233) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to ^0.22.0 (#8232) by @renovate[bot] - deps: update crate-ci/typos action to v1.43.3 (#8225) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.21.9 (#8224) by @renovate[bot] - deps: update crate-ci/typos action to v1.43.2 (#8212) by @renovate[bot] - remove rolldown_plugin_vite_wasm_helper (#8207) by @shulaoda - build docs for production (#8206) by @sapphi-red Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oxc's semantic analysis now detects and reports undefined exports as
PARSE_ERROR, making Rolldown's customEXPORT_UNDEFINED_VARIABLEerror redundant.Changes
ExportUndefinedVariableErrorvariant fromEventKindenumexport_undefined_variable.rsevent implementationBuildDiagnosticast_scanner/mod.rsto skip adding exports for undefined bindings (Oxc reports the error)event_kind_switcher.rsvia code generatorVerification
The existing test
export_undefined_variablenow receives the error from Oxc:Previously, Rolldown detected this after parsing; now Oxc catches it during semantic analysis.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.