Skip to content

test(dev): this.addWatchFile dependency should be preserved after reload#8165

Merged
graphite-app[bot] merged 1 commit intomainfrom
02-02-test_dev_this.addwatchfile_dependency_should_be_preserved_after_reload
Feb 4, 2026
Merged

test(dev): this.addWatchFile dependency should be preserved after reload#8165
graphite-app[bot] merged 1 commit intomainfrom
02-02-test_dev_this.addwatchfile_dependency_should_be_preserved_after_reload

Conversation

@sapphi-red
Copy link
Member

No description provided.

Copy link
Member Author

sapphi-red commented Feb 2, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sapphi-red sapphi-red requested a review from hyf0 February 2, 2026 06:46
@graphite-app graphite-app bot changed the base branch from 02-02-test_dev_correctly_assert_file_change to graphite-base/8165 February 2, 2026 07:13
@graphite-app graphite-app bot force-pushed the 02-02-test_dev_this.addwatchfile_dependency_should_be_preserved_after_reload branch from 6a3eed3 to ea3efcb Compare February 2, 2026 07:34
@graphite-app graphite-app bot force-pushed the graphite-base/8165 branch from 8233ddf to 05ca9be Compare February 2, 2026 07:34
@graphite-app graphite-app bot changed the base branch from graphite-base/8165 to main February 2, 2026 07:35
@graphite-app graphite-app bot force-pushed the 02-02-test_dev_this.addwatchfile_dependency_should_be_preserved_after_reload branch from ea3efcb to 7277c59 Compare February 2, 2026 07:35
@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 7277c59
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/698053a8fb98ed0008ae7784

@hyf0 hyf0 changed the base branch from main to graphite-base/8165 February 4, 2026 06:24
@hyf0 hyf0 force-pushed the 02-02-test_dev_this.addwatchfile_dependency_should_be_preserved_after_reload branch from 7277c59 to e17de3d Compare February 4, 2026 06:24
@hyf0 hyf0 changed the base branch from graphite-base/8165 to 02-04-fix_rust_preserve_dependencies_added_by_this.addwatchfile_ February 4, 2026 06:25
@hyf0 hyf0 requested a review from Copilot February 4, 2026 07:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive test coverage to verify that this.addWatchFile dependencies are correctly preserved after a dev server reload. The test extends two existing fixtures (transform-dependencies and load-dependencies) by adding a third test step that triggers a reload and then verifies HMR still works for watched dependencies.

Changes:

  • Adds a reload step using new unrelated.hmr-1.js files to trigger server reload
  • Adds config.hmr-2.json files to test HMR after reload with version 3 config
  • Updates main.js files to handle three test steps: initial HMR (ok-0), reload detection (ok-1), and post-reload HMR (ok-2)

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/test-dev-server/tests/fixtures/transform-dependencies/src/unrelated.hmr-1.js New file to trigger reload in step 1
packages/test-dev-server/tests/fixtures/transform-dependencies/src/main.js Updated to detect reload and handle version 2/3 configs
packages/test-dev-server/tests/fixtures/transform-dependencies/src/config.hmr-2.json New config file with version 3 for step 2 testing
packages/test-dev-server/tests/fixtures/load-dependencies/src/unrelated.hmr-1.js New file to trigger reload in step 1
packages/test-dev-server/tests/fixtures/load-dependencies/src/main.js Updated to detect reload and handle version 2/3 configs
packages/test-dev-server/tests/fixtures/load-dependencies/src/config.hmr-2.json New config file with version 3 for step 2 testing

@hyf0 hyf0 force-pushed the 02-02-test_dev_this.addwatchfile_dependency_should_be_preserved_after_reload branch from e17de3d to bfec6b4 Compare February 4, 2026 07:59
@hyf0
Copy link
Member

hyf0 commented Feb 4, 2026

Tests showed flakiness somehow. Probably could ignore it. @sapphi-red I also made some changes to the tests, could verify if they make sense.

@hyf0 hyf0 marked this pull request as ready for review February 4, 2026 07:59
Copy link
Member

hyf0 commented Feb 4, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 02-04-fix_rust_preserve_dependencies_added_by_this.addwatchfile_ branch from 6ca71f6 to 1dab36c Compare February 4, 2026 10:08
@graphite-app graphite-app bot force-pushed the 02-02-test_dev_this.addwatchfile_dependency_should_be_preserved_after_reload branch from bfec6b4 to a506273 Compare February 4, 2026 10:09
Base automatically changed from 02-04-fix_rust_preserve_dependencies_added_by_this.addwatchfile_ to main February 4, 2026 10:18
@graphite-app graphite-app bot merged commit a506273 into main Feb 4, 2026
29 checks passed
@graphite-app graphite-app bot deleted the 02-02-test_dev_this.addwatchfile_dependency_should_be_preserved_after_reload branch February 4, 2026 10:20
@github-actions github-actions bot mentioned this pull request Feb 4, 2026
shulaoda added a commit that referenced this pull request Feb 4, 2026
## [1.0.0-rc.3] - 2026-02-04

⚡ Remove Unnecessary Default Export Assignment

- Eliminates redundant variable assignments when exporting default values
- Reduces output bundle size and improves code clarity
```js
// index.js
var x = 42;
export default x;

// Before
var x = 42;
var entry_default = x;
export { entry_default as default };

// After
var x = 42;
export { x as default };
```

🐛 Avoid Unnecessary Facade Chunks

- Keep user-defined entry modules in their own chunks
- Reduces HTTP round trips and improves startup performance

```js
// main.js (entry module)
import { a } from './lib.js'
console.log(a)

// lib.js
export * from './counter.js'

// counter.js (entry module)
export const a = 100

// Before
dist/
├── main.js           → import { a } from './counter-chunk.js'; console.log(a)
├── counter.js        → export { a } from './counter-chunk.js' // ❌ facade chunk
└── counter-chunk.js  → export const a = 100

// After
dist/
├── main.js    → import { a } from './counter.js'; console.log(a)
└── counter.js → export const a = 100
```

### 🚀 Features

- expose `RUNTIME_MODULE_ID` constant for plugin authors (#8199) by @shulaoda
- warn unsupported combination of `preserveValueImports` and `importsNotUsedAsValues` in tsconfig.json (#8169) by @sapphi-red
- sophisticated watch tracking for load dependencies (#8092) by @sapphi-red
- add `inputMap` option to `minify` / `minifySync` functions (#8138) by @sapphi-red
- consolidate same tsconfig errors (#8119) by @sapphi-red
- include tsconfig file path in error messages (#8107) by @Copilot
- lazy-barrel: support incremental build mode (#8114) by @shulaoda

### 🐛 Bug Fixes

- rust: preserve dependencies added by `this.addWatchFile` (#8198) by @hyf0
- spawn `RuntimeModuleTask` after `build_start` to avoid race condition (#8182) by @shulaoda
- rust/dev: only close after the ongoing task finished (#8147) by @hyf0
- ensure `\0rolldown/runtime.js` will go through transform hook and add test (#8093) by @hyf0
- `[name]` in `assetFileNames` does not include the directory part (#8098) by @IWANABETHATGUY
- handle external module properties in namespace imports (#8124) by @IWANABETHATGUY
- keep user-defined entry modules in their own chunks (#8047) by @IWANABETHATGUY
- avoid `Unknown resolve error` error message (#8111) by @sapphi-red

### 💼 Other

- remove warnings  for building rolldown with `not(feature = "experimental")` (#8110) by @coolreader18

### 🚜 Refactor

- move `VERSION` to `constants` directory (#8200) by @shulaoda
- simplify import symbol check using `SymbolFlags` (#8193) by @shulaoda
- extract tsconfig option and transform options merging logic (#8168) by @sapphi-red
- filter empty module_groups before sorting (#8149) by @ShroXd
- lazy-barrel: use single `remove` instead of `contains_key` + `remove` (#8123) by @shulaoda
- lazy-barrel: avoid redundant call and inline `get_barrel_normal_module` (#8122) by @shulaoda
- use logger instead of console.log for warnings (#8117) by @IWANABETHATGUY
- module-loader: remove intermediate ModuleTaskOwnerRef type (#8113) by @shulaoda
- rename ReExportExternalModule to ReExportDynamicExports (#8104) by @IWANABETHATGUY

### 📚 Documentation

- add dynamic OG image generation (#8192) by @sapphi-red
- add dynamic OG image generation (#8191) by @sapphi-red
- add dynamic OG image generation (#8179) by @Copilot
- apis: add links to option descriptions in JSDoc comments (#8167) by @sapphi-red
- apis: clarify parameters of `resolveDynamicImport` hook (#8137) by @sapphi-red
- lazy-barrel: clarify default export behavior (#8128) by @shulaoda

### ⚡ Performance

- remove unnecessary assignment for default export (#8127) by @shulaoda

### 🧪 Testing

- dev: `this.addWatchFile` dependency should be preserved after reload (#8165) by @sapphi-red
- mark flaky `transform_runtime_module` test as ignored (#8178) by @Copilot
- rolldown_sourcemap: add test for coarse segments (#8166) by @sapphi-red
- dev: correctly assert file change (#8164) by @sapphi-red
- rust: `transform_runtime_module` test shouldn't panic inside (#8151) by @hyf0
- rust: fix flakiness of rust tests (#8150) by @hyf0
- mark `output.dynamicImportInCjs` tests as passed (#8125) by @shulaoda
- lazy-barrel: add test cases for default export (#8129) by @shulaoda
- rolldown_plugin_vite_manifest: use relative path for outPath (#8101) by @shulaoda

### ⚙️ Miscellaneous Tasks

- deps: update crate-ci/typos action to v1.43.1 (#8188) by @renovate[bot]
- deps: update rust crate ts-rs to v12 (#8160) by @renovate[bot]
- deps: update crate-ci/typos action to v1.43.0 (#8175) by @renovate[bot]
- deps: update rust crates (#8157) by @renovate[bot]
- deps: update oxc to v0.112.0 (#8171) by @renovate[bot]
- deps: update rollup submodule for tests to v4.57.1 (#8176) by @sapphi-red
- deps: update test262 submodule for tests (#8177) by @sapphi-red
- deps: update dependency oxlint to v1.43.0 (#8173) by @renovate[bot]
- deps: update dependency oxfmt to ^0.28.0 (#8170) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.21.8 (#8163) by @renovate[bot]
- deps: update dependency vue-router to v5 (#8159) by @renovate[bot]
- deps: update github-actions (#8158) by @renovate[bot]
- deps: update npm packages (#8156) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.4 (#8140) by @renovate[bot]
- fix clippy replacement typo (#8136) by @IWANABETHATGUY
- disallow `HashMap::new` and `HashSet::new` by clippy (#8135) by @sapphi-red
- deps: update dependency rolldown-plugin-dts to v0.21.7 (#8126) by @renovate[bot]
- deps: update oxc resolver to v11.17.0 (#8121) by @renovate[bot]
- deps: update dependency oxlint-tsgolint to v0.11.3 (#8109) by @renovate[bot]

### ❤️ New Contributors

* @coolreader18 made their first contribution in [#8110](#8110)

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants