refactor(rust/plugin): use Option<ModuleIdx>::None to represent invalid module idx#8152
Merged
shulaoda merged 1 commit intographite-base/8152from Feb 1, 2026
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label graphite: merge-when-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the plugin context structs to use Option<ModuleIdx> instead of a bare ModuleIdx to represent cases where no valid module index is available, particularly for NAPI contexts.
Changes:
- Modified
LoadPluginContextandTransformPluginContextto storemodule_idxasOption<ModuleIdx> - Updated all constructor calls to wrap valid module indices with
Some()and useNonefor NAPI contexts - Added conditional logic to only track dependencies when a valid module index exists
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/rolldown_plugin/src/plugin_driver/build_hooks.rs | Wrapped module_idx arguments with Some() when creating plugin contexts |
| crates/rolldown_plugin/src/plugin_context/transform_plugin_context.rs | Changed module_idx field to Option type and added conditional checks before using it |
| crates/rolldown_plugin/src/plugin_context/load_plugin_context.rs | Changed module_idx field to Option type and added conditional checks before using it |
| crates/rolldown_binding/src/options/plugin/binding_callable_builtin_plugin.rs | Used None for module_idx in NAPI contexts with explanatory comments |
Contributor
Benchmarks Rust
|
shulaoda
approved these changes
Feb 1, 2026
Member
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.