Skip to content

feat: minimum changes for wasi#810

Closed
hyf0 wants to merge 3 commits intomainfrom
hyf_wasi
Closed

feat: minimum changes for wasi#810
hyf0 wants to merge 3 commits intomainfrom
hyf_wasi

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Apr 9, 2024 •
edited by Brooooooklyn
Loading

  • rustup target add wasm32-wasi-preview1-threads
  • pnpm install
  • just roll-wasi

@netlify
Copy link

netlify bot commented Apr 9, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit c500157
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/661516e3ac040d000865ae67

@netlify
Copy link

netlify bot commented Apr 9, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 7b91a00
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6617e8dc65da0900083418c6

@codecov
Copy link

codecov bot commented Apr 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.66667% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 80.54%. Comparing base (2011bf4) to head (7b91a00).
Report is 12 commits behind head on main.

Files Patch % Lines
crates/rolldown/src/stages/scan_stage.rs 78.94% 4 Missing ⚠️
crates/rolldown_binding/src/bundler.rs 0.00% 4 Missing ⚠️
crates/rolldown/src/bundler.rs 57.14% 3 Missing ⚠️
...s/rolldown/src/module_loader/normal_module_task.rs 57.14% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #810      +/-   ##
==========================================
- Coverage   80.57%   80.54%   -0.04%     
==========================================
  Files         131      131              
  Lines        6627     6647      +20     
==========================================
+ Hits         5340     5354      +14     
- Misses       1287     1293       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 9, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #810 will not alter performance

Comparing hyf_wasi (51581bf) with main (3b81588)

Summary

✅ 6 untouched benchmarks

@hyf0 hyf0 changed the title wip: minimum wasm changes wip: minimum changes for wasi Apr 11, 2024
@hyf0 hyf0 mentioned this pull request Apr 11, 2024
Closed
@hyf0 hyf0 changed the title wip: minimum changes for wasi feat: minimum changes for wasi Apr 11, 2024
@Brooooooklyn Brooooooklyn deleted the hyf_wasi branch January 17, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @Brooooooklyn