Skip to content

test(lazy): add playground/lazy-compilation#7974

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-20-test_lazy_add_playground_lazy-compilation_
Apr 19, 2026
Merged

test(lazy): add playground/lazy-compilation#7974
graphite-app[bot] merged 1 commit intomainfrom
01-20-test_lazy_add_playground_lazy-compilation_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Jan 20, 2026

Basic test to make sure the lazy compilation is worked and code runs successfully

Solves #7955

Copy link
Copy Markdown
Member Author

hyf0 commented Jan 20, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 20, 2026

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 8a5b573
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/69e4651eb6e741000876fc69

@hyf0 hyf0 marked this pull request as ready for review January 20, 2026 15:37
Copilot AI review requested due to automatic review settings January 20, 2026 15:37
Comment thread packages/test-dev-server/tests/vitest-setup-playwright.ts
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new test playground for lazy compilation functionality and refactors the test infrastructure to support multiple dev servers running in parallel. The changes enable testing of lazy compilation behavior alongside existing HMR tests.

Changes:

  • Added new playground/lazy-compilation with test files and configuration to verify lazy module loading
  • Refactored test setup to support multiple dev servers and browser pages running concurrently
  • Updated port configuration to avoid conflicts (HMR: 3636, Lazy: 3637)

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/test-dev-server/tests/vitest.config.browser.mts Added lazy-compilation test to test suite and disabled file parallelism for shared setup
packages/test-dev-server/tests/vitest-setup-playwright.ts Refactored to support multiple dev servers and pages, with parallel initialization
packages/test-dev-server/tests/test-utils.ts Added getLazyPage() helper function for lazy compilation tests
packages/test-dev-server/tests/src/config.ts Added paths and ports for lazy compilation playground
packages/test-dev-server/tests/playground/lazy-compilation/package.json Package configuration for lazy compilation playground
packages/test-dev-server/tests/playground/lazy-compilation/main.js Main entry point that dynamically imports lazy module
packages/test-dev-server/tests/playground/lazy-compilation/lazy-module.js Lazily loaded module with HMR support
packages/test-dev-server/tests/playground/lazy-compilation/index.html HTML page for lazy compilation test
packages/test-dev-server/tests/playground/lazy-compilation/dev.config.mjs Dev server configuration with lazy compilation enabled
packages/test-dev-server/tests/playground/hmr-full-bundle-mode/dev.config.mjs Updated port to 3636 to avoid conflicts
packages/test-dev-server/tests/lazy-compilation.spec.ts Test spec verifying lazy module loading behavior
knip.jsonc Added lazy-compilation playground entry points
Comments suppressed due to low confidence (1)

packages/test-dev-server/tests/vitest-setup-playwright.ts:49

  • The function comment mentions "Files that are modified during tests" but only references hmr-full-bundle-mode.spec.ts. With the addition of lazy-compilation tests, this comment should be updated to clarify that it only applies to HMR tests, or the function should be extended to support lazy compilation test files if they need editing in the future.
/**
 * Files that are modified during tests and need to be reset on retry.
 * These files correspond to the source files edited by editFile() calls in hmr-full-bundle-mode.spec.ts.
 * If new files are edited in tests, add them here to ensure proper reset on retry.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/test-dev-server/tests/lazy-compilation.spec.ts Outdated
Comment thread packages/test-dev-server/tests/vitest.config.browser.mts Outdated
Comment thread packages/test-dev-server/tests/vitest-setup-playwright.ts
@hyf0 hyf0 force-pushed the 01-20-test_lazy_add_playground_lazy-compilation_ branch from 1f3d448 to a687fa7 Compare January 21, 2026 10:09
Copilot AI review requested due to automatic review settings January 21, 2026 12:19
@hyf0 hyf0 force-pushed the 01-20-test_lazy_add_playground_lazy-compilation_ branch from a687fa7 to 90c7fcb Compare January 21, 2026 12:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/test-dev-server/tests/vitest-setup-browser.ts
Comment thread packages/test-dev-server/tests/vitest-setup-browser.ts Outdated
Comment thread packages/test-dev-server/tests/lazy-compilation.spec.ts Outdated
@hyf0 hyf0 force-pushed the 01-20-test_lazy_add_playground_lazy-compilation_ branch from 90c7fcb to 5580ae0 Compare January 21, 2026 15:54
Copilot AI review requested due to automatic review settings January 21, 2026 18:11
@hyf0 hyf0 force-pushed the 01-20-test_lazy_add_playground_lazy-compilation_ branch from 5580ae0 to dd7f3be Compare January 21, 2026 18:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/test-dev-server/tests/vitest-setup-browser.ts Outdated
Comment thread packages/test-dev-server/tests/vitest-setup-browser.ts Outdated
Comment thread packages/test-dev-server/tests/test-utils.ts Outdated
Comment thread packages/test-dev-server/tests/test-utils.ts Outdated
@h-a-n-a
Copy link
Copy Markdown
Member

h-a-n-a commented Apr 16, 2026

@copilot resolve the merge conflicts in this pull request

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts by merging origin/main into this branch and finalizing the conflict resolution in commit 9c93704. There are no UI changes in this update, so no screenshot applies.

Copilot AI requested a review from h-a-n-a April 16, 2026 10:06
hyf0 added a commit that referenced this pull request Apr 18, 2026
## Summary
- Adds a `run-windows` output to the `changes` job that is `true` on
`main` or when the PR has the `ci: windows` label
- Gates `build-rolldown-windows`, `node-test-windows`,
`node-dev-server-test-windows`, `vite-test-windows`, and the
`cargo-test` Windows matrix entry on this output
- macOS CI remains gated on `main` only (unchanged)

## How to use
1. Add the `ci: windows` label to your PR
2. Push a commit — Windows jobs will run
3. Remove the label when no longer needed

For making testing on Windows easier. Ref
#7974

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@hyf0 hyf0 force-pushed the 01-20-test_lazy_add_playground_lazy-compilation_ branch from 9c93704 to 08b8a17 Compare April 18, 2026 04:40
@hyf0 hyf0 force-pushed the 01-20-test_lazy_add_playground_lazy-compilation_ branch from e16f77e to b71bbf0 Compare April 18, 2026 13:11
@hyf0 hyf0 marked this pull request as ready for review April 18, 2026 15:01
@hyf0 hyf0 force-pushed the 01-20-test_lazy_add_playground_lazy-compilation_ branch 4 times, most recently from 1f8d259 to 3a5f9e6 Compare April 18, 2026 16:23
@hyf0 hyf0 requested a review from sapphi-red April 18, 2026 16:45
@hyf0 hyf0 force-pushed the 01-20-test_lazy_add_playground_lazy-compilation_ branch from 01aaead to 60d830d Compare April 18, 2026 16:48
Copy link
Copy Markdown
Member Author

hyf0 commented Apr 19, 2026

Merge activity

Basic test to make sure the lazy compilation is worked and code runs successfully

Solves #7955
@graphite-app graphite-app Bot force-pushed the 01-20-test_lazy_add_playground_lazy-compilation_ branch from 624e41e to 8a5b573 Compare April 19, 2026 05:16
@graphite-app graphite-app Bot merged commit 8a5b573 into main Apr 19, 2026
31 of 32 checks passed
@graphite-app graphite-app Bot deleted the 01-20-test_lazy_add_playground_lazy-compilation_ branch April 19, 2026 05:20
@github-actions github-actions Bot mentioned this pull request Apr 22, 2026
This was referenced Apr 22, 2026
shulaoda added a commit that referenced this pull request Apr 22, 2026
## [1.0.0-rc.17] - 2026-04-22

### 🐛 Bug Fixes

- link: error on missing export between TS modules (#9197) by @IWANABETHATGUY
- rolldown_plugin_vite_import_glob: import path should not be affected by absolute base option (#9145) by @kermanx
- `this.resolve()` returns null for bare relative paths without importer (#9142) by @Copilot
- collect destructured bindings in HMR module exports (#9146) by @h-a-n-a
- esbuild-tests: handle 0.28.0 test cases (#9149) by @sapphi-red
- plugin/copy-module: honor external resolutions from other plugins (#9139) by @TheAlexLichter
- allow undefined in sourcesContent type (#9136) by @jurijzahn8019
- reduce false positives in chunk optimizer circular dependency detection (#9049) by @AlonMiz

### 🚜 Refactor

- chunk-optimizer: extract runtime-module placement into rehome_runtime_module (#9163) by @IWANABETHATGUY

### 📚 Documentation

- add design doc for sort_modules execution ordering (#9169) by @IWANABETHATGUY
- add document for `RenderedModule` (#9147) by @sapphi-red

### ⚡ Performance

- rolldown_plugin_vite_import_glob: skip self-import earlier using raw path comparison (#9193) by @shulaoda

### 🧪 Testing

- lazy: add `playground/lazy-compilation` (#7974) by @hyf0

### ⚙️ Miscellaneous Tasks

- use app token for release PR (#9198) by @Boshen
- upgrade oxc to 0.127.0 (#9194) by @Dunqing
- use oxc security action (#9196) by @Boshen
- esbuild-tests: remove some tests from ignored list as enum inline is now supported (#9184) by @sapphi-red
- deps: update dependency vite-plus to v0.1.19 (#9183) by @renovate[bot]
- use vp instead of pnpm in check-wasi-binding-deps (#9182) by @shulaoda
- verify wasm32-wasi binding deps match @rolldown/browser before publish (#9162) by @shulaoda
- deps: update esbuild for tests to 0.28.0 (#9172) by @sapphi-red
- deps: update rollup submodule for tests to v4.60.2 (#9173) by @sapphi-red
- deps: update test262 submodule for tests (#9174) by @sapphi-red
- sort_modules: fix stale async-entry sort key comment (#9170) by @IWANABETHATGUY
- deps: update npm packages (#9157) by @renovate[bot]
- deps: update dependency diff to v9 (#9158) by @renovate[bot]
- deps: update rust crates (#9156) by @renovate[bot]
- run Windows CI on PRs labeled with `ci: windows` (#9153) by @hyf0
- update-test-dependencies: run setup-rust before file changes (#9151) by @sapphi-red
- deps: update dependency rust to v1.95.0 (#9140) by @renovate[bot]

### ❤️ New Contributors

* @jurijzahn8019 made their first contribution in [#9136](#9136)
* @AlonMiz made their first contribution in [#9049](#9049)

---------

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants