Skip to content

refactor: string_wizard error hanlding#7830

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-10-feat_string_wizard_error_hanlding
Jan 11, 2026
Merged

refactor: string_wizard error hanlding#7830
graphite-app[bot] merged 1 commit intomainfrom
01-10-feat_string_wizard_error_hanlding

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author

IWANABETHATGUY commented Jan 9, 2026


How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot force-pushed the 01-10-feat_nativemagicstring_reset branch 2 times, most recently from 4aae8cc to 6e32891 Compare January 10, 2026 07:36
@graphite-app graphite-app bot force-pushed the 01-10-feat_string_wizard_error_hanlding branch from 8ac27a9 to 5740dc7 Compare January 10, 2026 07:36
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review January 11, 2026 10:57
@github-actions
Copy link
Contributor

github-actions bot commented Jan 11, 2026

Benchmarks Rust

  • target: main(1b4e346)
  • pr: 01-10-feat_string_wizard_error_hanlding(30cb3d4)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     65.7±1.24ms        ? ?/sec    1.00     65.9±1.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     71.6±1.04ms        ? ?/sec    1.01     72.1±2.43ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    102.9±2.67ms        ? ?/sec    1.00    102.0±1.49ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    113.7±1.94ms        ? ?/sec    1.00    113.7±1.45ms        ? ?/sec
bundle/bundle@threejs                                        1.02     38.1±2.38ms        ? ?/sec    1.00     37.5±2.17ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     42.3±0.66ms        ? ?/sec    1.00     42.0±0.58ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    377.0±2.54ms        ? ?/sec    1.01    379.6±4.39ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    438.8±3.44ms        ? ?/sec    1.01    441.1±3.49ms        ? ?/sec
scan/scan@rome_ts                                            1.01     81.4±2.37ms        ? ?/sec    1.00     80.9±1.56ms        ? ?/sec
scan/scan@threejs                                            1.00     28.2±1.42ms        ? ?/sec    1.01     28.6±1.71ms        ? ?/sec
scan/scan@threejs10x                                         1.00    287.8±4.08ms        ? ?/sec    1.01    291.2±4.33ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-10-feat_string_wizard_error_hanlding branch from 5740dc7 to fd1e4f9 Compare January 11, 2026 13:53
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-10-feat_nativemagicstring_reset branch from 6e32891 to 089f981 Compare January 11, 2026 13:53
@graphite-app graphite-app bot changed the base branch from 01-10-feat_nativemagicstring_reset to graphite-base/7830 January 11, 2026 14:07
@IWANABETHATGUY IWANABETHATGUY force-pushed the 01-10-feat_string_wizard_error_hanlding branch from bc58753 to c7b2bcb Compare January 11, 2026 14:19
@graphite-app graphite-app bot changed the base branch from graphite-base/7830 to main January 11, 2026 14:20
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 11, 2026

Merge activity

  • Jan 11, 2:20 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Jan 11, 2:52 PM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
  • Jan 11, 3:02 PM UTC: Merged by the Graphite merge queue.

@IWANABETHATGUY IWANABETHATGUY changed the title feat: string_wizard error hanlding refactor: string_wizard error hanlding Jan 11, 2026
@graphite-app graphite-app bot force-pushed the 01-10-feat_string_wizard_error_hanlding branch from c7b2bcb to 30cb3d4 Compare January 11, 2026 14:52
@netlify
Copy link

netlify bot commented Jan 11, 2026

Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 30cb3d4
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6963b921becca90008de6d07
😎 Deploy Preview https://deploy-preview-7830--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@graphite-app graphite-app bot merged commit 30cb3d4 into main Jan 11, 2026
35 checks passed
@graphite-app graphite-app bot deleted the 01-10-feat_string_wizard_error_hanlding branch January 11, 2026 15:02
This was referenced Jan 14, 2026
shulaoda added a commit that referenced this pull request Jan 14, 2026
## [1.0.0-beta.60] - 2026-01-14

### 💥 BREAKING CHANGES

- tsconfig: enable auto-discovery by default (#7817) by @shulaoda

### 🚀 Features

- distinguish transformer diagnostics from parse errors (#7872) by @shulaoda
- emit transformer warnings instead of ignoring them (#7850) by @shulaoda
- node: add `output.codeSplitting` option and deprecate `output.advancedChunks` (#7855) by @hyf0
- nativeMagicString reset (#7828) by @IWANABETHATGUY
- nativeMagicString lastChar (#7819) by @IWANABETHATGUY
- dev/lazy: inject lazy compilation runtime automatically (#7816) by @hyf0
- nativeMagicString snip (#7818) by @IWANABETHATGUY
- nativeMagicString construct with options (#7814) by @IWANABETHATGUY
- nativeMagicString clone (#7813) by @IWANABETHATGUY
- nativeMagicString `insert` (#7812) by @IWANABETHATGUY
- nativeMagicString `slice` (#7807) by @IWANABETHATGUY
- nativeMagicString trim methods (#7800) by @IWANABETHATGUY
- make closeBundle hook receive the last error (#7278) by @Copilot

### 🐛 Bug Fixes

- when package only contains export default, cjsDefault didn't resolve correctly (#7873) by @IWANABETHATGUY
- inline __name calls for default exports  (#7862) by @IWANABETHATGUY
- improve variable renaming to avoid unnecessary shadowing in nested scopes (#7859) by @IWANABETHATGUY
- use correct index when inserting keepNames statements during export default transformation (#7853) by @IWANABETHATGUY
- transform non-static dynamic imports when `dynamicImportInCjs` is `false` (#7823) by @shulaoda
- dev/lazy: should include imported and non-executed modules in the patch (#7815) by @hyf0
- set ExportsKind to Esm when json is none object literal  (#7808) by @IWANABETHATGUY
- nativeMagicString move api (#7796) by @IWANABETHATGUY
- remove unnecessary exports after merging into commong and user defined entry (#7789) by @IWANABETHATGUY
- use output.name instead of chunk.name in mixed export warning (#7788) by @Copilot

### 🚜 Refactor

- generalize ParseError to OxcError with dynamic EventKind (#7868) by @shulaoda
- rust: rename `advanced_chunks` to `manual_code_splitting` (#7856) by @hyf0
- string_wizard error hanlding (#7830) by @IWANABETHATGUY
- remove `experimental.disableLiveBindings` option (#7820) by @sapphi-red
- node/test: run fixture tests in concurrent (#7790) by @hyf0
- move ConfigExport and RolldownOptionsFunction types to define-config (#7799) by @shulaoda
- cli: validate config after resolving and improve error message (#7798) by @shulaoda

### 📚 Documentation

- rebrand (#7670) by @yyx990803
- fix incorrect default value for propertyReadSideEffects (#7847) by @Copilot
- remove options pages and redirect to reference pages (#7834) by @sapphi-red
- options: inline types to option property pages (#7831) by @sapphi-red
- options: port checks.pluginTimings content from options page to reference page (#7832) by @sapphi-red
- options: use `@linkcode` where possible (#7824) by @sapphi-red
- options: port content from options page to reference page (#7822) by @sapphi-red
- options: add descriptions for output options (#7821) by @sapphi-red
- options: add description for input options (#7802) by @sapphi-red
- options: add description for `checks.*` (#7801) by @sapphi-red
- apis: add hook graph (#7671) by @sapphi-red

### 🧪 Testing

- add all valid combination of chunk exports related test (#7851) by @IWANABETHATGUY
- enable MagicString test after api return type alignment (#7797) by @IWANABETHATGUY
- init magic-string test (#7794) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- vite-tests: configure git user for rebase operation (#7875) by @shulaoda
- rolldown_binding: remove v3 native plugins (#7837) by @shulaoda
- rolldown_binding: allow crate-type as lib (#7866) by @Brooooooklyn
- README.md: adjust position and size of rolldown logo (#7861) by @hyf0
- deps: update test262 submodule for tests (#7857) by @sapphi-red
- deps: update oxc to v0.108.0 (#7845) by @renovate[bot]
- deps: update dependency oxlint to v1.39.0 (#7849) by @renovate[bot]
- deps: update dependency oxfmt to ^0.24.0 (#7844) by @renovate[bot]
- deps: update npm packages (#7841) by @renovate[bot]
- deps: update rust crates (#7839) by @renovate[bot]
- deps: update github-actions (#7840) by @renovate[bot]
- use workspace edition for all crates (#7829) by @IWANABETHATGUY
- deps: update dependency oxlint-tsgolint to v0.11.0 (#7827) by @renovate[bot]
- deps: update napi to v3.8.2 (#7810) by @renovate[bot]
- remove outdated snapshot files (#7806) by @shulaoda
- deps: update crate-ci/typos action to v1.42.0 (#7792) by @renovate[bot]

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants