feat: support vite-style tsconfig resolution by shulaoda · Pull Request #6873 · rolldown/rolldown

shulaoda · 2025-11-07T09:59:21Z

shulaoda · 2025-11-07T09:59:38Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-11-07T10:00:27Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`ed8b7ef`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6926a9abeb91d700075186af

Related to #6873

github-actions · 2025-11-10T03:21:49Z

Benchmarks Rust

target: main(facd6a8)
pr: 11-07-feat_support_vite-style_tsconfig_resolution(ed8b7ef)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     63.8±1.72ms        ? ?/sec    1.01     64.1±1.73ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.01     70.2±2.70ms        ? ?/sec    1.00     69.6±3.39ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    108.2±2.49ms        ? ?/sec    1.00    106.8±1.47ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    120.2±1.73ms        ? ?/sec    1.00    119.6±1.93ms        ? ?/sec
bundle/bundle@threejs                                        1.02     41.0±2.73ms        ? ?/sec    1.00     40.2±2.25ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     43.8±0.86ms        ? ?/sec    1.00     43.5±0.93ms        ? ?/sec
bundle/bundle@threejs10x                                     1.05    410.9±5.42ms        ? ?/sec    1.00    391.2±3.95ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.03    466.2±9.85ms        ? ?/sec    1.00    450.8±3.54ms        ? ?/sec
scan/scan@rome_ts                                            1.01     85.6±1.65ms        ? ?/sec    1.00     85.0±1.62ms        ? ?/sec
scan/scan@threejs                                            1.04     29.5±2.10ms        ? ?/sec    1.00     28.4±0.40ms        ? ?/sec
scan/scan@threejs10x                                         1.00    297.2±4.84ms        ? ?/sec    1.00    296.0±4.54ms        ? ?/sec

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

crates/rolldown/src/utils/prepare_build_context.rs:1

The find_tsconfig operation is called on every file transformation in Auto mode. While there's caching of the merged options, the tsconfig lookup itself might be repeated. Verify that oxc_resolver's find_tsconfig has its own internal caching, otherwise consider adding a path-to-tsconfig-path cache to avoid redundant filesystem lookups.

use std::{borrow::Cow, path::Path, sync::Arc};

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_testing/_config.schema.json

crates/rolldown/src/utils/pre_process_ecma_ast.rs

crates/rolldown_common/src/inner_bundler_options/types/transform_options.rs

crates/rolldown/src/utils/pre_process_ecma_ast.rs

crates/rolldown_common/src/inner_bundler_options/types/transform_options.rs

crates/rolldown/src/utils/pre_process_ecma_ast.rs

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_testing/_config.schema.json

crates/rolldown/src/utils/prepare_build_context.rs

crates/rolldown/src/utils/pre_process_ecma_ast.rs

crates/rolldown/src/utils/prepare_build_context.rs

Co-authored-by: 翠 <green@sapphi.red> Signed-off-by: dalaoshu <165626830+shulaoda@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_resolver/src/resolver.rs

crates/rolldown_common/src/inner_bundler_options/types/transform_options.rs

crates/rolldown_common/src/inner_bundler_options/types/tsconfig.rs

crates/rolldown/src/utils/prepare_build_context.rs

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_common/src/inner_bundler_options/types/transform_options.rs

crates/rolldown/src/utils/prepare_build_context.rs

crates/rolldown_common/src/inner_bundler_options/types/transform_options.rs

crates/rolldown/src/utils/pre_process_ecma_ast.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: dalaoshu <165626830+shulaoda@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch 2 times, most recently from 8c37566 to 334316b Compare November 9, 2025 13:01

shulaoda mentioned this pull request Nov 9, 2025

test: add tsconfig include/exclude/files matching test cases #6899

Merged

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from 334316b to c25dac4 Compare November 9, 2025 13:05

shulaoda mentioned this pull request Nov 9, 2025

chore(deps): update oxc_resolver and oxc_resolver_napi #6901

Merged

graphite-app bot pushed a commit that referenced this pull request Nov 9, 2025

chore(deps): update oxc_resolver and oxc_resolver_napi (#6901)

da9490c

Related to #6873

shulaoda changed the base branch from main to graphite-base/6873 November 10, 2025 03:01

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from c25dac4 to 73a2089 Compare November 10, 2025 03:01

shulaoda changed the base branch from graphite-base/6873 to 11-10-chore_deps_update_oxc_resolver November 10, 2025 03:01

shulaoda mentioned this pull request Nov 10, 2025

chore(deps): update oxc_resolver #6909

Merged

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from 73a2089 to 489db0b Compare November 10, 2025 03:05

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from 489db0b to c4a2a6d Compare November 10, 2025 03:23

shulaoda force-pushed the 11-10-chore_deps_update_oxc_resolver branch from 71adc3a to 78d72da Compare November 10, 2025 03:23

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from c4a2a6d to 12ef7f3 Compare November 10, 2025 13:39

shulaoda self-assigned this Nov 22, 2025

shulaoda changed the base branch from 11-10-chore_deps_update_oxc_resolver to graphite-base/6873 November 22, 2025 20:10

shulaoda force-pushed the graphite-base/6873 branch from 78d72da to 34581da Compare November 22, 2025 20:19

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from 12ef7f3 to 77e8bf3 Compare November 22, 2025 20:19

shulaoda changed the base branch from graphite-base/6873 to 11-10-chore_deps_update_oxc_resolver November 22, 2025 20:19

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from 77e8bf3 to 1020a16 Compare November 22, 2025 20:31

shulaoda force-pushed the 11-10-chore_deps_update_oxc_resolver branch from 34581da to b103b65 Compare November 22, 2025 20:57

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch 2 times, most recently from f10920d to 4d14185 Compare November 22, 2025 21:23

shulaoda force-pushed the 11-10-chore_deps_update_oxc_resolver branch from b103b65 to 5daa2c4 Compare November 22, 2025 21:29

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch 2 times, most recently from 7e521e1 to d65d0c7 Compare November 23, 2025 16:49

shulaoda force-pushed the 11-10-chore_deps_update_oxc_resolver branch from 5daa2c4 to 5973e86 Compare November 23, 2025 16:49

Copilot finished reviewing on behalf of shulaoda November 26, 2025 06:42

Copilot AI reviewed Nov 26, 2025

View reviewed changes

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from 44fda45 to 6164491 Compare November 26, 2025 06:45

feat: support vite-style tsconfig resolution

26e4526

Copilot AI review requested due to automatic review settings November 26, 2025 06:53

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from 6164491 to 26e4526 Compare November 26, 2025 06:53

Copilot started reviewing on behalf of shulaoda November 26, 2025 06:54 View session

Copilot finished reviewing on behalf of shulaoda November 26, 2025 06:56

graphite-app bot reviewed Nov 26, 2025

View reviewed changes

crates/rolldown/src/utils/pre_process_ecma_ast.rs Show resolved Hide resolved

Copilot AI reviewed Nov 26, 2025

View reviewed changes

crates/rolldown_testing/_config.schema.json Show resolved Hide resolved

crates/rolldown/src/utils/prepare_build_context.rs Outdated Show resolved Hide resolved

sapphi-red approved these changes Nov 26, 2025

View reviewed changes

crates/rolldown/src/utils/pre_process_ecma_ast.rs Show resolved Hide resolved

crates/rolldown/src/utils/prepare_build_context.rs Outdated Show resolved Hide resolved

Update crates/rolldown/src/utils/prepare_build_context.rs

b3f40cd

Co-authored-by: 翠 <green@sapphi.red> Signed-off-by: dalaoshu <165626830+shulaoda@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 26, 2025 07:02

Copilot started reviewing on behalf of shulaoda November 26, 2025 07:03 View session

Copilot finished reviewing on behalf of shulaoda November 26, 2025 07:07

Copilot AI reviewed Nov 26, 2025

View reviewed changes

u

90e5f86

Copilot AI review requested due to automatic review settings November 26, 2025 07:09

shulaoda force-pushed the 11-07-feat_support_vite-style_tsconfig_resolution branch from c26ba66 to 90e5f86 Compare November 26, 2025 07:09

Copilot started reviewing on behalf of shulaoda November 26, 2025 07:10 View session

Copilot finished reviewing on behalf of shulaoda November 26, 2025 07:15

Copilot AI reviewed Nov 26, 2025

View reviewed changes

Update crates/rolldown/src/utils/prepare_build_context.rs

ed8b7ef

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: dalaoshu <165626830+shulaoda@users.noreply.github.com>

Copilot AI review requested due to automatic review settings November 26, 2025 07:18

Copilot started reviewing on behalf of shulaoda November 26, 2025 07:18 View session

Copilot finished reviewing on behalf of shulaoda November 26, 2025 07:20

Copilot AI reviewed Nov 26, 2025

View reviewed changes

shulaoda merged commit 5c30011 into main Nov 26, 2025
35 checks passed

shulaoda mentioned this pull request Nov 26, 2025

docs(tsconfig): document auto-discovery mode and improve structure #7228

Merged

github-actions bot mentioned this pull request Nov 26, 2025

release: v1.0.0-beta.52 #7229

Merged

Conversation

shulaoda commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

github-actions bot commented Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shulaoda commented Nov 7, 2025 •

edited

Loading

shulaoda commented Nov 7, 2025 •

edited

Loading

netlify bot commented Nov 7, 2025 •

edited

Loading

github-actions bot commented Nov 10, 2025 •

edited

Loading