Skip to content

fix: track spans in member expression properties for accurate sourcemaps#6100

Merged
graphite-app[bot] merged 1 commit intomainfrom
09-09-fix_6099
Sep 10, 2025
Merged

fix: track spans in member expression properties for accurate sourcemaps#6100
graphite-app[bot] merged 1 commit intomainfrom
09-09-fix_6099

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Sep 9, 2025 •
edited
Loading

Closed #6099

The issue was already solved by #6091. This pr adds a test case for the sourcemapping generation

@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Sep 9, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Sep 9, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-09-refactor_member_expr_construction_in_ast_snippets branch from b4834d2 to dd4a70b Compare September 9, 2025 11:38
@IWANABETHATGUY IWANABETHATGUY changed the title fix: 6099 test: add sourcemap test for issue #6099 Sep 9, 2025
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 9, 2025 11:40
@IWANABETHATGUY IWANABETHATGUY linked an issue Sep 9, 2025 that may be closed by this pull request
sourcemapping did not generate correctly #6099
Closed
sapphi-red
sapphi-red reviewed Sep 9, 2025
View reviewed changes
@graphite-app graphite-app bot changed the base branch from 09-09-refactor_member_expr_construction_in_ast_snippets to graphite-base/6100 September 9, 2025 12:08
@IWANABETHATGUY IWANABETHATGUY changed the base branch from graphite-base/6100 to main September 9, 2025 13:03
@IWANABETHATGUY IWANABETHATGUY changed the title test: add sourcemap test for issue #6099 fix: add sourcemap test for issue #6099 Sep 9, 2025
@IWANABETHATGUY IWANABETHATGUY changed the title fix: add sourcemap test for issue #6099 fix: track spans in member expression properties for accurate sourcemaps Sep 9, 2025
@netlify
Copy link

netlify bot commented Sep 9, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit cf4ad6a
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68c0ef0a69644d000838ac51

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025 •
edited
Loading

Benchmarks Rust

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.05     91.1±3.06ms        ? ?/sec    1.00     87.0±2.62ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.04    100.9±2.01ms        ? ?/sec    1.00     97.3±1.85ms        ? ?/sec
bundle/bundle@rome_ts                                        1.06    128.1±3.41ms        ? ?/sec    1.00    121.2±2.39ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.01    146.6±2.59ms        ? ?/sec    1.00    144.5±3.90ms        ? ?/sec
bundle/bundle@threejs                                        1.04     48.8±3.43ms        ? ?/sec    1.00     46.8±1.07ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     55.9±0.86ms        ? ?/sec    1.00     54.7±1.10ms        ? ?/sec
bundle/bundle@threejs10x                                     1.07   501.6±10.93ms        ? ?/sec    1.00    470.0±4.36ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.08   586.6±18.17ms        ? ?/sec    1.00    544.7±5.22ms        ? ?/sec
scan/scan@rome_ts                                            1.03     96.8±2.66ms        ? ?/sec    1.00     94.3±2.29ms        ? ?/sec
scan/scan@threejs                                            1.04     34.4±0.68ms        ? ?/sec    1.00     33.1±0.34ms        ? ?/sec
scan/scan@threejs10x                                         1.02    360.5±3.85ms        ? ?/sec    1.00    353.3±3.64ms        ? ?/sec

@sapphi-red
Copy link
Member

sapphi-red commented Sep 10, 2025

Maybe we can improve the test infra to verify the stacktrace is same like oxc-project/oxc#13351 does.

@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 10, 2025 •
edited
Loading

Merge activity

@IWANABETHATGUY
fix: track spans in member expression properties for accurate sourcem…
cf4ad6a 
…aps (#6100)

Closed #6099

The issue was already solved by #6091. This pr adds a test case for the sourcemapping generation
@graphite-app graphite-app bot merged commit cf4ad6a into main Sep 10, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 09-09-fix_6099 branch September 10, 2025 03:32
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Sep 10, 2025
Open
@github-actions github-actions bot mentioned this pull request Sep 10, 2025
Merged
Boshen added a commit that referenced this pull request Sep 10, 2025
@github-actions @Boshen
release: v1.0.0-beta.37 (#6131)
a97dcbe 
## [1.0.0-beta.37] - 2025-09-10

### 🚀 Features

- partial align with const inline strategy with oxc in smart mode
(#6126) by @IWANABETHATGUY
- dev: use PathsMut for non-debounced RecommendedWatcher (#6120) by
@sapphi-red
- dev: return whether the build is already scheduled from
`scheduleBuildIfStale` method (#6116) by @sapphi-red
- handle errors from `BundlerBuilder#build` (#6104) by @shulaoda
- add debounceTickRate option for debounced watchers (#6113) by @hyf0
- support full build in `incrementalBuild` mode (#6098) by
@IWANABETHATGUY
- add compare_contents_for_polling option to dev watcher (#6108) by
@hyf0
- dev: add `scheduleBuildIfStale` method to DevEngine (#6087) by
@sapphi-red
- dev: return changed files in onHmrUpdates callback (#6086) by
@sapphi-red
- support function config with custom CLI arguments (#6076) by
@IWANABETHATGUY
- improve `MISSING_EXPORT` warning to suggest `type` modifier (#6085) by
@sapphi-red
- crates/rolldown_watcher: introduce `PathsMut` to batch watch/unwatch
behaviors (#6075) by @hyf0
- enable `treeshake.commonjs` by default (#6072) by @IWANABETHATGUY
- dev: add debounce control and PollWatcher support to DevWatchOptions
(#6070) by @hyf0

### 🐛 Bug Fixes

- use kqueue for file watch on mac (#6124) by @sapphi-red
- use patched notify for better file change event debouncing (#6125) by
@sapphi-red
- support passing all js primitive value for `alias` plugin (#6123) by
@IWANABETHATGUY
- track spans in member expression properties for accurate sourcemaps
(#6100) by @IWANABETHATGUY
- correctly handle inlined CommonJS exports in member expressions
(#6090) by @IWANABETHATGUY
- dev: ensure patch file names to be unique (#6096) by @sapphi-red
- dev: normalize slash on Windows before comparing paths (#6095) by
@sapphi-red
- dev/watch: debounce duration should default to 10 (#6078) by @hyf0

### 🚜 Refactor

- simplify `__export` runtime helper to create target object internally
(#6114) by @IWANABETHATGUY
- simplify module_namespace construction second try (#6118) by
@IWANABETHATGUY
- simplify module_namespace construction (#5939) by @IWANABETHATGUY
- optimize member expression creation in AstSnippet (#6091) by
@IWANABETHATGUY
- test-dev-server: sensible watcher configuration for CI env (#6077) by
@hyf0

### 🧪 Testing

- dev: apply HMR edits on Windows (#6094) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- Revert "chore: adjust breaking change template of cliff (#6069)"
(#6130) by @IWANABETHATGUY
- test-dev-server: improve hmr test configuration (#6115) by @hyf0
- deps: update dependency rolldown-plugin-dts to v0.16.2 (#6128) by
@renovate[bot]
- Revert "refactor: simplify module_namespace construction (#5939)"
(#6117) by @IWANABETHATGUY
- test-dev-server: optimize test log output (#6107) by @hyf0
- enable compare_contents_for_polling and update poll interval for CI
test-dev-server (#6110) by @hyf0
- deps: update dependency vite to v7.1.5 [security] (#6111) by
@renovate[bot]
- fix warnings reported by `just lint` (#6105) by @shulaoda
- deps: update dependency tsdown to v0.15.0 (#6102) by @renovate[bot]
- use debug builds for browser tests in CI (#6092) by @hyf0
- test-dev-server: update polling interval and add retry logic for CI
tests (#6088) by @hyf0
- adjust breaking change template of cliff (#6069) by @IWANABETHATGUY

### ◀️ Revert

- "fix: replace_plugin does not work as expected with .ts config
(#5920)" (#6074) by @IWANABETHATGUY

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sapphi-red sapphi-red sapphi-red approved these changes

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sourcemapping did not generate correctly

2 participants

@IWANABETHATGUY @sapphi-red