Skip to content

chore: remove unused warning for conditional compiledSimplifyMinifyOptions#6047

Merged
IWANABETHATGUY merged 1 commit intomainfrom
09-08-chore_remove_unused_warning_for_conditional_compiled_simplifyminifyoptions_
Sep 8, 2025
Merged

chore: remove unused warning for conditional compiledSimplifyMinifyOptions#6047
IWANABETHATGUY merged 1 commit intomainfrom
09-08-chore_remove_unused_warning_for_conditional_compiled_simplifyminifyoptions_

Conversation

@IWANABETHATGUY
Copy link
Member

No description provided.

Copy link
Member Author

IWANABETHATGUY commented Sep 8, 2025

@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-08-chore_remove_unused_warning_for_conditional_compiled_simplifyminifyoptions_ branch from 2efa357 to cb496a3 Compare September 8, 2025 04:02
Base automatically changed from 09-08-fix_just_command_in_ci to main September 8, 2025 04:04
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review September 8, 2025 04:06
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-08-chore_remove_unused_warning_for_conditional_compiled_simplifyminifyoptions_ branch from cb496a3 to 0ab5ea8 Compare September 8, 2025 04:10
@netlify
Copy link

netlify bot commented Sep 8, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e8c2cd4
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68be5fd6bd60d00008373b35

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

Benchmarks Rust

  • target: main(d63973d)
  • pr: 09-08-chore_remove_unused_warning_for_conditional_compiled_simplifyminifyoptions_(e8c2cd4)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     83.2±4.61ms        ? ?/sec    1.00     83.3±3.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     91.0±3.03ms        ? ?/sec    1.06     96.6±5.74ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    122.6±2.31ms        ? ?/sec    1.02    125.2±2.57ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    143.8±3.93ms        ? ?/sec    1.00    144.4±3.87ms        ? ?/sec
bundle/bundle@threejs                                        1.00     46.0±1.60ms        ? ?/sec    1.01     46.4±1.15ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     54.6±1.59ms        ? ?/sec    1.02     55.8±1.22ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    479.2±6.00ms        ? ?/sec    1.00    481.1±5.12ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    561.4±8.28ms        ? ?/sec    1.00    562.3±9.22ms        ? ?/sec
scan/scan@rome_ts                                            1.01     97.7±2.91ms        ? ?/sec    1.00     97.0±2.73ms        ? ?/sec
scan/scan@threejs                                            1.00     33.9±2.06ms        ? ?/sec    1.02     34.6±1.24ms        ? ?/sec
scan/scan@threejs10x                                         1.00    357.1±3.76ms        ? ?/sec    1.01    362.0±8.46ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Sep 8, 2025
@IWANABETHATGUY IWANABETHATGUY removed this pull request from the merge queue due to a manual request Sep 8, 2025
@IWANABETHATGUY IWANABETHATGUY force-pushed the 09-08-chore_remove_unused_warning_for_conditional_compiled_simplifyminifyoptions_ branch from 0ab5ea8 to e8c2cd4 Compare September 8, 2025 04:47
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Sep 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 8, 2025
@IWANABETHATGUY IWANABETHATGUY merged commit 0fc94b9 into main Sep 8, 2025
25 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 09-08-chore_remove_unused_warning_for_conditional_compiled_simplifyminifyoptions_ branch September 8, 2025 05:53
@github-actions github-actions bot mentioned this pull request Sep 8, 2025
shulaoda added a commit that referenced this pull request Sep 8, 2025
## [1.0.0-beta.36] - 2025-09-08
> [!warning]
> ### 💥 BREAKING CHANGES
> 
> - drop CJS format, increase minimum required node (#6025) by @sxzz


### 🚀 Features

- rolldown_plugin_reporter: statically imported dynamic import warning (#6065) by @shulaoda
- rolldown_plugin_reporter: warn large chunks (#6063) by @shulaoda
- rolldown: oxc v0.87.0 (#5975) by @Boshen

### 🐛 Bug Fixes

- allow keeping whitespace while enabling minify (#5893) by @sapphi-red
- dev/watch: build connection between file in `this.addWatchFile` and currently transformed module during transform hook (#6048) by @hyf0
- validator of `output.minify` (#6062) by @IWANABETHATGUY
- codspeed rust benchmark ci (#6052) by @IWANABETHATGUY
- just command in ci (#6045) by @IWANABETHATGUY
- watch: only consider files read from disk are able to watch (#6037) by @hyf0

### 🚜 Refactor

- dev: introduce `DevWatchOptions` for enhanced file watching configuration (#6057) by @hyf0
- unify to use `is_in_node_modules` from `rolldown_plugin_utils` (#6066) by @shulaoda

### 🧪 Testing

- rust: ensure unused pure function call got treeshaked (#4524) by @hyf0
- hmr: tweak improper test (#6034) by @hyf0
- hmr: add test of editing multiple files in the same timeframe (#6029) by @hyf0
- hmr: support to edit multiple files in the same timeframe (#6014) by @hyf0

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance rust crates (#6003) by @renovate[bot]
- deps: lock file maintenance npm packages (#5995) by @renovate[bot]
- add auto-assign PR workflow for organization members (#6058) by @IWANABETHATGUY
- fix benchmark-node workflow (#6060) by @IWANABETHATGUY
- adding `test-node-rolldown-only` just command (#6055) by @IWANABETHATGUY
- just commands in ci (#6056) by @IWANABETHATGUY
- run test ci when `justfile` is changed (#6049) by @IWANABETHATGUY
- remove unused warning for conditional compiled`SimplifyMinifyOptions` (#6047) by @IWANABETHATGUY
- remove auto approval ci (#6051) by @IWANABETHATGUY
- adding rustfmt components for `repo-validation` (#6053) by @IWANABETHATGUY
- repo: check format/style in `just lint-rust` (#6050) by @hyf0
- repo/ai: refine `justfile` (#6038) by @hyf0
- repo/ai: add `AGENTS.md` and `CLAUDE.md` (#6039) by @hyf0
- deps: update github-actions (major) (#6041) by @renovate[bot]
- deps: update github-actions (#6040) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.16.1 (#6035) by @renovate[bot]

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants