feat: support source maps without original source code#5732
feat: support source maps without original source code#5732AliceLanniste wants to merge 4 commits intorolldown:mainfrom
Conversation
|
You didn't add the options to the TS typings in binding.d.ts. They should get generated after a build as demonstrated by the test. |
|
I wonder why there is no getter in |
|
And you also still need to add it in the actually exported TS definitions in options/output-options.ts and options/normalized-output-options.ts. |
|
@I-Enderlord-I ,hi I don't understand why must add getter in BindingNormalizedOptions and options in options/output-options.ts,can you explain ? |
|
I don't fully understand the project structure myself (thus why I didn't make a pull request), but as far as I see, the typescript files in Specifically, the As for adding the getter to |
|
I think I get it now... Check out #2987 to see where passing additional properties to the JS/TS API requires changes. That still leaves receiving more in |
|
Ok I was correct. See cf09f46 for everything a new options requires. |
|
@I-Enderlord-I THANK YOU SO MUCH |
|
Maybe adding a test to |
close #5554