feat: pass the remaining normalized fields from rust to js#2987
Merged
hyf0 merged 1 commit intorolldown:mainfrom Nov 29, 2024
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #2906
I've mostly aligned
NormalizedOutputOptionswithrollup. IfNormalizedInputOptionsisn't needed, we can close this issue.The following fields are unique to us:
rolldown/packages/rolldown/src/options/normalized-output-options.ts
Lines 40 to 41 in 71e6863
I haven't handled this because converting
HybridRegexin rust to js regex is challenging:rolldown/packages/rolldown/src/options/output-options.ts
Lines 58 to 67 in 71e6863