Skip to content

chore(deps): do not enable full feature for tokio#5238

Merged
Boshen merged 1 commit intomainfrom
07-10-chore_deps_do_not_enable_full_feature_for_tokio_
Jul 10, 2025
Merged

chore(deps): do not enable full feature for tokio#5238
Boshen merged 1 commit intomainfrom
07-10-chore_deps_do_not_enable_full_feature_for_tokio_

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Jul 10, 2025

No description provided.

@netlify
Copy link

netlify bot commented Jul 10, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 93320b7
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/686f7f7711683f0008874f25

@Boshen Boshen self-assigned this Jul 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2025

Benchmarks Rust

  • target: main(af400d3)
  • pr: 07-10-chore_deps_do_not_enable_full_feature_for_tokio_(93320b7)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     78.0±1.98ms        ? ?/sec    1.00     77.4±2.53ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.03     91.3±2.62ms        ? ?/sec    1.00     88.5±1.87ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    116.7±4.27ms        ? ?/sec    1.00    115.0±1.90ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    135.1±2.28ms        ? ?/sec    1.01    136.1±1.70ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.6±2.56ms        ? ?/sec    1.01     42.9±2.54ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     50.9±0.86ms        ? ?/sec    1.04     52.9±1.00ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    452.8±6.17ms        ? ?/sec    1.00    448.8±4.53ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    524.9±5.09ms        ? ?/sec    1.00    521.5±4.33ms        ? ?/sec
scan/scan@rome_ts                                            1.00     90.6±1.66ms        ? ?/sec    1.03     93.4±2.29ms        ? ?/sec
scan/scan@threejs                                            1.00     31.5±2.02ms        ? ?/sec    1.00     31.4±0.81ms        ? ?/sec
scan/scan@threejs10x                                         1.00    327.2±5.00ms        ? ?/sec    1.01    331.2±3.52ms        ? ?/sec

@Boshen
Copy link
Member Author

Boshen commented Jul 10, 2025

The feature flag is on rolldown_bench, it won't affect production.

@Boshen Boshen added this pull request to the merge queue Jul 10, 2025
Merged via the queue into main with commit 1aae3b3 Jul 10, 2025
46 checks passed
@Boshen Boshen deleted the 07-10-chore_deps_do_not_enable_full_feature_for_tokio_ branch July 10, 2025 09:47
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 10, 2025

Open in StackBlitz

@rolldown/browser

npm i https://pkg.pr.new/@rolldown/browser@5238

@rolldown/debug

npm i https://pkg.pr.new/@rolldown/debug@5238

@rolldown/pluginutils

npm i https://pkg.pr.new/@rolldown/pluginutils@5238

rolldown

npm i https://pkg.pr.new/rolldown@5238

@rolldown/binding-darwin-arm64

npm i https://pkg.pr.new/@rolldown/binding-darwin-arm64@5238

@rolldown/binding-darwin-x64

npm i https://pkg.pr.new/@rolldown/binding-darwin-x64@5238

@rolldown/binding-freebsd-x64

npm i https://pkg.pr.new/@rolldown/binding-freebsd-x64@5238

@rolldown/binding-linux-arm-gnueabihf

npm i https://pkg.pr.new/@rolldown/binding-linux-arm-gnueabihf@5238

@rolldown/binding-linux-arm64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-gnu@5238

@rolldown/binding-linux-arm64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-arm64-musl@5238

@rolldown/binding-linux-x64-gnu

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-gnu@5238

@rolldown/binding-linux-x64-musl

npm i https://pkg.pr.new/@rolldown/binding-linux-x64-musl@5238

@rolldown/binding-wasm32-wasi

npm i https://pkg.pr.new/@rolldown/binding-wasm32-wasi@5238

@rolldown/binding-win32-arm64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-arm64-msvc@5238

@rolldown/binding-win32-ia32-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-ia32-msvc@5238

@rolldown/binding-win32-x64-msvc

npm i https://pkg.pr.new/@rolldown/binding-win32-x64-msvc@5238

commit: 93320b7

@github-actions github-actions bot mentioned this pull request Jul 10, 2025
Merged
shulaoda added a commit that referenced this pull request Jul 10, 2025
@github-actions @shulaoda
release: v1.0.0-beta.26 (#5245)
4398e03 
## [1.0.0-beta.26] - 2025-07-10

### 🐛 Bug Fixes

- browser: process is not defined error (#5241) by @sapphi-red
- plugin/vite-resolve: allow resolving bare specifiers to relative paths
for entries (#5230) by @sapphi-red

### ⚙️ Miscellaneous Tasks

- deps: do not enable `full` feature for `tokio` (#5238) by @Boshen

Co-authored-by: shulaoda <165626830+shulaoda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Boshen Boshen

Labels

trigger: preview

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen @shulaoda