Skip to content

refactor(rust): ensure module can only be wrapped via wrap_module_recursively#4669

Merged
hyf0 merged 1 commit intomainfrom
05-25-refactor_rust_ensure_module_can_only_be_wrapped_via_wrap_module_recursively_
May 25, 2025
Merged

refactor(rust): ensure module can only be wrapped via wrap_module_recursively#4669
hyf0 merged 1 commit intomainfrom
05-25-refactor_rust_ensure_module_can_only_be_wrapped_via_wrap_module_recursively_

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented May 25, 2025

Description

@hyf0 hyf0 marked this pull request as ready for review May 25, 2025 10:38
@hyf0 Graphite App
Copy link
Member Author

hyf0 commented May 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented May 25, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 3017222
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6832f322ecc95f0008793d3f

@hyf0 hyf0 mentioned this pull request May 25, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2025

Benchmarks Rust

  • target: main(caf7510)
  • pr: 05-25-refactor_rust_ensure_module_can_only_be_wrapped_via_wrap_module_recursively_(3017222)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     76.8±1.33ms        ? ?/sec    1.07     82.0±2.74ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     95.0±1.64ms        ? ?/sec    1.05    100.0±1.54ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    108.3±0.78ms        ? ?/sec    1.05    113.3±0.92ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     88.5±2.04ms        ? ?/sec    1.03     90.8±0.94ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    116.8±1.02ms        ? ?/sec    1.03    119.9±1.28ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.05   210.6±13.09ms        ? ?/sec    1.00    200.1±2.30ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    223.1±2.08ms        ? ?/sec    1.13    251.2±5.86ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    131.3±2.20ms        ? ?/sec    1.00    131.5±1.53ms        ? ?/sec
bundle/bundle@threejs                                               1.01     41.4±1.52ms        ? ?/sec    1.00     40.8±0.33ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     81.2±0.37ms        ? ?/sec    1.02     83.0±0.83ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.02    101.8±1.46ms        ? ?/sec    1.00     99.9±1.94ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     46.5±0.54ms        ? ?/sec    1.02     47.5±0.54ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    423.5±3.67ms        ? ?/sec    1.00    424.6±5.17ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1006.1±4.71ms        ? ?/sec    1.01   1012.8±5.97ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1191.1±4.65ms        ? ?/sec    1.01   1199.9±5.74ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    488.1±3.26ms        ? ?/sec    1.01    490.6±3.25ms        ? ?/sec
remapping/remapping                                                 1.00     27.1±0.51ms        ? ?/sec    1.02     27.6±0.71ms        ? ?/sec
remapping/render-chunk-remapping                                    1.10     73.7±5.50ms        ? ?/sec    1.00     67.2±1.54ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     89.7±0.97ms        ? ?/sec    1.05     94.1±0.86ms        ? ?/sec
scan/scan@threejs                                                   1.00     30.5±1.22ms        ? ?/sec    1.06     32.3±2.02ms        ? ?/sec
scan/scan@threejs10x                                                1.00    306.1±2.97ms        ? ?/sec    1.03    316.2±2.59ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue May 25, 2025
Merged via the queue into main with commit 5746d19 May 25, 2025
35 checks passed
@hyf0 hyf0 deleted the 05-25-refactor_rust_ensure_module_can_only_be_wrapped_via_wrap_module_recursively_ branch May 25, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY