feat(pluginutils): add exactRegex and prefixRegex#4458
Merged
sapphi-red merged 2 commits intorolldown:mainfrom May 9, 2025
Merged
feat(pluginutils): add exactRegex and prefixRegex#4458sapphi-red merged 2 commits intorolldown:mainfrom
exactRegex and prefixRegex#4458sapphi-red merged 2 commits intorolldown:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces two new functions, exactRegex and prefixRegex, to support improved plugin hook filtering for the @rolldown/pluginutils package. It also refactors the module exports by removing inline type and helper definitions from index.ts and moving them into a separate composableFilters.ts file.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/pluginutils/src/simpleFilters.ts | Adds exactRegex, prefixRegex, and an escapeRegex helper function. |
| packages/pluginutils/src/index.ts | Refactors exports to only re-export from composableFilters.js and simpleFilters.js. |
| packages/pluginutils/src/composableFilters.ts | Introduces the composable filters implementation previously inlined in index.ts. |
Comments suppressed due to low confidence (1)
packages/pluginutils/src/index.ts:1
- Verify that the file extensions in the exports match your build output. If using TypeScript, consider using extension-less imports (e.g. './composableFilters') to improve maintainability and avoid module resolution issues.
export * from './composableFilters.js';
IWANABETHATGUY
approved these changes
May 9, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 9, 2025
<!-- Thank you for contributing! --> ### Description test for #4458 <!-- Please insert your description here and provide especially info about the "what" this PR is solving -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same with rollup/plugins#1865.
But for
@rolldown/pluginutilsso that we can release this.