Skip to content

feat(rust): support LegalComments::Inline#4444

Merged
hyf0 merged 1 commit intomainfrom
05-08-feat_rust_support_legalcomments_inline_
May 8, 2025
Merged

feat(rust): support LegalComments::Inline#4444
hyf0 merged 1 commit intomainfrom
05-08-feat_rust_support_legalcomments_inline_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented May 8, 2025 •
edited
Loading

Description

An alignment with esbuild's option.

@hyf0 hyf0 mentioned this pull request May 8, 2025
Merged
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented May 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review May 8, 2025 08:29
@hyf0 hyf0 force-pushed the 05-08-feat_rust_support_legalcomments_inline_ branch 2 times, most recently from 4530f8b to 8512587 Compare May 8, 2025 08:31
@hyf0 hyf0 force-pushed the 05-08-refactor_rust_rename_comments_to_legal_comments_ branch from 3e70b4b to 00ed588 Compare May 8, 2025 08:31
@hyf0 hyf0 force-pushed the 05-08-feat_rust_support_legalcomments_inline_ branch from 8512587 to 76823b4 Compare May 8, 2025 08:37
graphite-app[bot]
graphite-app bot reviewed May 8, 2025
View reviewed changes
@hyf0 hyf0 force-pushed the 05-08-feat_rust_support_legalcomments_inline_ branch from 76823b4 to e7c8be4 Compare May 8, 2025 08:48
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 8, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(dedce11)
  • pr: 05-08-feat_rust_support_legalcomments_inline_(4f3a826)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.01     86.9±2.46ms        ? ?/sec    1.00     86.2±1.62ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00    105.7±2.22ms        ? ?/sec    1.00    105.6±2.21ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    121.0±1.78ms        ? ?/sec    1.01    122.4±1.91ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     92.2±1.83ms        ? ?/sec    1.00     90.7±3.76ms        ? ?/sec
bundle/bundle@rome-ts                                               1.03    125.3±2.56ms        ? ?/sec    1.00    121.8±2.74ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    222.1±4.47ms        ? ?/sec    1.01    225.4±4.77ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    252.5±5.04ms        ? ?/sec    1.05    265.3±4.92ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.03    137.1±1.77ms        ? ?/sec    1.00    133.2±3.04ms        ? ?/sec
bundle/bundle@threejs                                               1.00     42.7±1.94ms        ? ?/sec    1.05     44.6±2.77ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     83.6±1.10ms        ? ?/sec    1.08     90.3±2.17ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    101.6±3.76ms        ? ?/sec    1.07    108.3±3.23ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.4±0.99ms        ? ?/sec    1.03     49.7±0.68ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00   426.7±11.69ms        ? ?/sec    1.03    438.1±6.74ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1049.6±8.62ms        ? ?/sec    1.02   1068.5±9.26ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1254.1±17.85ms        ? ?/sec    1.00  1257.6±12.76ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00   502.9±18.46ms        ? ?/sec    1.02    515.4±5.01ms        ? ?/sec
remapping/remapping                                                 1.03     26.3±0.20ms        ? ?/sec    1.00     25.5±0.95ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     65.8±2.73ms        ? ?/sec    1.03     67.5±5.04ms        ? ?/sec
scan/scan@rome-ts                                                   1.08     99.4±0.95ms        ? ?/sec    1.00     92.3±1.16ms        ? ?/sec
scan/scan@threejs                                                   1.03     33.4±0.70ms        ? ?/sec    1.00     32.5±1.25ms        ? ?/sec
scan/scan@threejs10x                                                1.05    328.5±3.92ms        ? ?/sec    1.00    311.8±3.15ms        ? ?/sec

Base automatically changed from 05-08-refactor_rust_rename_comments_to_legal_comments_ to main May 8, 2025 10:17
@hyf0 hyf0 force-pushed the 05-08-feat_rust_support_legalcomments_inline_ branch from e7c8be4 to 4f3a826 Compare May 8, 2025 10:18
@netlify
Copy link
Copy Markdown

netlify bot commented May 8, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 4f3a826
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/681c84ffa6afc1000809edba

@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app bot commented May 8, 2025

Merge activity

  • May 8, 6:19 AM EDT: Graphite rebased this pull request, because this pull request is set to merge when ready.

@hyf0 hyf0 requested a review from shulaoda May 8, 2025 10:44
@hyf0 hyf0 added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit 6921d6c May 8, 2025
29 checks passed
@hyf0 hyf0 deleted the 05-08-feat_rust_support_legalcomments_inline_ branch May 8, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @shulaoda