Skip to content

fix: align resolve extension order with esbuild#4277

Merged
shulaoda merged 1 commit intomainfrom
04-24-fix_align_resolve_extension_order_with_esbuild
Apr 23, 2025
Merged

fix: align resolve extension order with esbuild#4277
shulaoda merged 1 commit intomainfrom
04-24-fix_align_resolve_extension_order_with_esbuild

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Apr 23, 2025 •
edited
Loading

@hyf0 Graphite App
Copy link
Member Author

hyf0 commented Apr 23, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 mentioned this pull request Apr 23, 2025
Merged
@hyf0 hyf0 marked this pull request as ready for review April 23, 2025 17:08
@hyf0 hyf0 mentioned this pull request Apr 23, 2025
Open
@hyf0 hyf0 force-pushed the 04-24-fix_align_resolve_extension_order_with_esbuild branch 2 times, most recently from 87871fb to 90cb31b Compare April 23, 2025 17:15
@hyf0 hyf0 force-pushed the 04-24-fix_should_try_to_resolve_.json_extension_by_default branch from 36dda63 to 43a9b83 Compare April 23, 2025 17:15
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(e84206b)
  • pr: 04-24-fix_align_resolve_extension_order_with_esbuild(f6e026c)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.07     78.6±1.10ms        ? ?/sec    1.00     73.5±1.59ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.06    100.9±1.37ms        ? ?/sec    1.00     95.2±3.33ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.06    114.3±1.36ms        ? ?/sec    1.00    108.0±0.91ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.08     90.3±2.16ms        ? ?/sec    1.00     83.3±1.26ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    124.1±3.02ms        ? ?/sec    1.00    122.6±1.17ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    204.5±2.39ms        ? ?/sec    1.00    203.0±5.89ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.04    246.0±5.24ms        ? ?/sec    1.00    237.0±2.06ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.01    137.4±2.13ms        ? ?/sec    1.00    135.7±1.06ms        ? ?/sec
bundle/bundle@threejs                                               1.00     42.9±0.87ms        ? ?/sec    1.00     43.1±0.78ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     87.2±2.07ms        ? ?/sec    1.00     86.1±0.65ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    101.3±0.55ms        ? ?/sec    1.01    102.8±1.90ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     49.4±0.65ms        ? ?/sec    1.01     50.0±1.97ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    434.9±5.79ms        ? ?/sec    1.00    436.3±3.87ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1083.1±7.23ms        ? ?/sec    1.00   1079.2±5.22ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01   1270.6±7.12ms        ? ?/sec    1.00  1263.0±11.94ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    511.0±4.65ms        ? ?/sec    1.00    513.4±5.90ms        ? ?/sec
remapping/remapping                                                 1.01     27.7±1.15ms        ? ?/sec    1.00     27.3±0.39ms        ? ?/sec
remapping/render-chunk-remapping                                    1.04     74.0±6.14ms        ? ?/sec    1.00     71.4±4.87ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     98.4±1.52ms        ? ?/sec    1.00     97.0±0.85ms        ? ?/sec
scan/scan@threejs                                                   1.02     32.6±0.49ms        ? ?/sec    1.00     32.0±0.40ms        ? ?/sec
scan/scan@threejs10x                                                1.01    322.8±4.07ms        ? ?/sec    1.00    319.5±2.55ms        ? ?/sec

Base automatically changed from 04-24-fix_should_try_to_resolve_.json_extension_by_default to main April 23, 2025 17:54
@hyf0 hyf0 force-pushed the 04-24-fix_align_resolve_extension_order_with_esbuild branch from 90cb31b to f6e026c Compare April 23, 2025 17:54
@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 23, 2025

Merge activity

  • Apr 23, 1:55 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@netlify
Copy link

netlify bot commented Apr 23, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit f6e026c
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/68092956ccd5de0008a51c15

@hyf0 hyf0 added this pull request to the merge queue Apr 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2025
@hyf0
fix: align resolve extension order with esbuild (#4277)
1ca44c6 
<!-- Thank you for contributing! -->

### Description


https://esbuild.github.io/api/#resolve-extensions:~:text=The%20full%20order%20of%20implicit%20file%20extensions%20in%20esbuild%20can%20be%20customized%20using%20the%20resolve%20extensions%20setting%2C%20which%20defaults%20to

<!-- Please insert your description here and provide especially info
about the "what" this PR is solving -->
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Apr 23, 2025
@shulaoda shulaoda added this pull request to the merge queue Apr 23, 2025
Merged via the queue into main with commit 6565161 Apr 23, 2025
28 checks passed
@shulaoda shulaoda deleted the 04-24-fix_align_resolve_extension_order_with_esbuild branch April 23, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shulaoda shulaoda shulaoda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @shulaoda