Skip to content

refactor: use boolean instead of Result<bool> in filter_transform#4060

Merged
IWANABETHATGUY merged 1 commit intomainfrom
04-08-refactor_use_boolean_instead_of_result_bool_in_filter_transform
Apr 8, 2025
Merged

refactor: use boolean instead of Result<bool> in filter_transform#4060
IWANABETHATGUY merged 1 commit intomainfrom
04-08-refactor_use_boolean_instead_of_result_bool_in_filter_transform

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Apr 8, 2025

Description

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Apr 8, 2025
Merged
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Apr 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 8, 2025 12:55
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(92f7cc6)
  • pr: 04-08-refactor_use_boolean_instead_of_result_bool_in_filter_transform(e60911f)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     71.0±1.04ms        ? ?/sec    1.01     71.5±1.00ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     91.6±0.88ms        ? ?/sec    1.01     92.8±1.55ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    104.6±1.65ms        ? ?/sec    1.00    105.0±0.93ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.05     85.6±9.62ms        ? ?/sec    1.00     81.3±0.92ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    119.5±1.96ms        ? ?/sec    1.01    120.2±1.81ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    191.0±1.51ms        ? ?/sec    1.01    192.6±1.80ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    232.9±1.58ms        ? ?/sec    1.01    235.4±1.49ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    132.1±1.46ms        ? ?/sec    1.00    132.2±1.38ms        ? ?/sec
bundle/bundle@threejs                                               1.00     40.9±1.68ms        ? ?/sec    1.00     41.0±0.54ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     83.7±1.03ms        ? ?/sec    1.01     84.2±0.68ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     98.6±0.75ms        ? ?/sec    1.02    100.6±2.16ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     47.4±0.70ms        ? ?/sec    1.01     47.7±0.58ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    423.4±5.23ms        ? ?/sec    1.01   428.0±13.99ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1039.0±5.64ms        ? ?/sec    1.00   1040.1±5.29ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   1219.6±7.63ms        ? ?/sec    1.00   1216.6±5.53ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    489.4±3.07ms        ? ?/sec    1.02   497.7±16.58ms        ? ?/sec
remapping/remapping                                                 1.02     25.4±0.16ms        ? ?/sec    1.00     24.9±2.94ms        ? ?/sec
remapping/render-chunk-remapping                                    1.02     65.0±0.95ms        ? ?/sec    1.00     63.7±0.41ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     93.6±1.21ms        ? ?/sec    1.00     92.9±1.12ms        ? ?/sec
scan/scan@threejs                                                   1.01     31.4±0.43ms        ? ?/sec    1.00     31.1±0.35ms        ? ?/sec
scan/scan@threejs10x                                                1.00    314.6±3.91ms        ? ?/sec    1.01    318.0±7.19ms        ? ?/sec

Base automatically changed from 04-08-fix_multiple_transform_filter_option to main April 8, 2025 17:54
@IWANABETHATGUY IWANABETHATGUY force-pushed the 04-08-refactor_use_boolean_instead_of_result_bool_in_filter_transform branch from 5aac135 to e60911f Compare April 8, 2025 17:55
@netlify
Copy link

netlify bot commented Apr 8, 2025

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit e60911f
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67f562f721a4d200080d1f0e

@graphite-app
Copy link
Contributor

graphite-app bot commented Apr 8, 2025

Merge activity

  • Apr 8, 1:55 PM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit 8d551a2 Apr 8, 2025
28 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 04-08-refactor_use_boolean_instead_of_result_bool_in_filter_transform branch April 8, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IWANABETHATGUY @hyf0