feat: missing export error#396
Closed
underfin wants to merge 3 commits into
Closed
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 26, 2023
hyf0
reviewed
Jan 5, 2024
|
|
||
| #[derive(Debug, Clone, Hash, PartialEq, Eq)] | ||
| pub struct SpecifierLiteral { | ||
| pub span: Span, |
Member
There was a problem hiding this comment.
I'm not sure if we need add span here and introduce SpecifierLiteral struct here. I'm gonna on hold this PR before I think through it.
Member
There was a problem hiding this comment.
Oxc has the same thing https://github.com/oxc-project/oxc/blob/8a3eff1beebc693023e2dfd4035ddcab8cdc739e/crates/oxc_syntax/src/module_record.rs#L75-L79
#[derive(Debug, Clone, PartialEq, Eq)]
pub struct NameSpan {
name: Atom,
span: Span,
}Maybe a rename to NameSpan is all we need here?
2462fe6 to
a00c94c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support give a warning for import/export not matching. Here is an example, the warning message is port from rollup.
Test Plan
Added.