Skip to content

fix: imports with only types are removed even if verbatimModuleSyntax is true#3784

Merged
IWANABETHATGUY merged 2 commits intomainfrom
03-08-fix_imports_with_only_types_are_removed_even_if_verbatimmodulesyntax_is_true
Mar 8, 2025
Merged

fix: imports with only types are removed even if verbatimModuleSyntax is true#3784
IWANABETHATGUY merged 2 commits intomainfrom
03-08-fix_imports_with_only_types_are_removed_even_if_verbatimmodulesyntax_is_true

Conversation

@IWANABETHATGUY
Copy link
Member

@IWANABETHATGUY IWANABETHATGUY commented Mar 8, 2025 •
edited
Loading

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Mar 8, 2025
Merged
@IWANABETHATGUY Graphite App
Copy link
Member Author

IWANABETHATGUY commented Mar 8, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review March 8, 2025 04:22
@IWANABETHATGUY IWANABETHATGUY force-pushed the 03-08-fix_imports_with_only_types_are_removed_even_if_verbatimmodulesyntax_is_true branch from d9db755 to c0d0809 Compare March 8, 2025 04:25
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025

Benchmarks Rust

  • target: 03-08-chore_bump_oxc_resolver(c7a16d2)
  • pr: 03-08-fix_imports_with_only_types_are_removed_even_if_verbatimmodulesyntax_is_true(c0d0809)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     74.5±0.76ms        ? ?/sec    1.03     76.5±2.09ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     95.9±1.25ms        ? ?/sec    1.01     96.4±1.89ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    108.6±1.00ms        ? ?/sec    1.01    109.3±1.80ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     83.2±1.16ms        ? ?/sec    1.01     83.9±1.16ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    125.4±1.32ms        ? ?/sec    1.01    126.4±2.37ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.01    209.4±3.71ms        ? ?/sec    1.00    208.3±3.38ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    243.6±5.99ms        ? ?/sec    1.00    242.9±4.54ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    138.3±2.10ms        ? ?/sec    1.00    138.1±1.57ms        ? ?/sec
bundle/bundle@threejs                                               1.00     42.0±1.36ms        ? ?/sec    1.04     43.8±2.40ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.02     89.3±3.13ms        ? ?/sec    1.00     87.4±0.57ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    102.3±1.30ms        ? ?/sec    1.00    102.6±0.90ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     48.4±0.55ms        ? ?/sec    1.01     48.8±0.33ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    438.4±4.38ms        ? ?/sec    1.01    444.5±4.19ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1097.5±6.71ms        ? ?/sec    1.01  1109.6±10.44ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1300.2±15.39ms        ? ?/sec    1.00   1295.3±8.28ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    508.7±3.93ms        ? ?/sec    1.01    515.0±4.39ms        ? ?/sec
remapping/remapping                                                 1.01     27.7±0.71ms        ? ?/sec    1.00     27.3±0.31ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     68.4±5.32ms        ? ?/sec    1.02     69.7±6.12ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     97.3±1.53ms        ? ?/sec    1.00     96.8±2.05ms        ? ?/sec
scan/scan@threejs                                                   1.00     32.2±1.00ms        ? ?/sec    1.00     32.1±1.26ms        ? ?/sec
scan/scan@threejs10x                                                1.00    324.8±4.57ms        ? ?/sec    1.00    323.5±3.58ms        ? ?/sec

Base automatically changed from 03-08-chore_bump_oxc_resolver to main March 8, 2025 04:45
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Mar 8, 2025
Merged via the queue into main with commit ff8d19d Mar 8, 2025
22 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the 03-08-fix_imports_with_only_types_are_removed_even_if_verbatimmodulesyntax_is_true branch March 8, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: imports with only types are removed even if verbatimModuleSyntax is true

2 participants

@IWANABETHATGUY @hyf0