test(node): improve tests related to customized output filenames#3761
Closed
shulaoda wants to merge 1 commit intorolldown:mainfrom
Closed
test(node): improve tests related to customized output filenames#3761shulaoda wants to merge 1 commit intorolldown:mainfrom
shulaoda wants to merge 1 commit intorolldown:mainfrom
Conversation
0ec78d1 to
25cfe3b
Compare
25cfe3b to
1a976d3
Compare
shulaoda
commented
Mar 4, 2025
Comment on lines
+1
to
+4
| // Since we have customized the output `entry_filenames`, | ||
| // the `compiled_entries` in the following context is incorrect. | ||
| // | ||
| // /crates/rolldown_testing/src/integration_test.rs#L471-L484 |
Member
Author
There was a problem hiding this comment.
We need to add a _test.mjs file to prevent test failures caused by the inability to correctly recognize the entry after customizing the output entry_filenames.
Member
|
I have some different opinions about the test migration, need to discuss it in the next meeting. |
Member
|
I update the principle about testing, #3856 |
Member
|
Did we have a consensus for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #3256
I have consolidated all
rust-sidetests related to outputfilenamesand removed unnecessary tests on thenodeside.