Skip to content

feat: auto merge options from tsconfig to transformOption#3566

Merged
IWANABETHATGUY merged 1 commit intomainfrom
02-12-feat_auto_merge_options_from_tsconfig_to_transformoption
Feb 16, 2025
Merged

feat: auto merge options from tsconfig to transformOption#3566
IWANABETHATGUY merged 1 commit intomainfrom
02-12-feat_auto_merge_options_from_tsconfig_to_transformoption

Conversation

@IWANABETHATGUY
Copy link
Copy Markdown
Member

@IWANABETHATGUY IWANABETHATGUY commented Feb 12, 2025 •
edited
Loading

Description

1.Closed #2296
2. Closed #3473

@IWANABETHATGUY Graphite App
Copy link
Copy Markdown
Member Author

IWANABETHATGUY commented Feb 12, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Feb 12, 2025
Merged
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-12-feat_auto_merge_options_from_tsconfig_to_transformoption branch from 7331a3b to 71ddc38 Compare February 12, 2025 12:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 12, 2025 •
edited
Loading

Benchmarks Rust

  • target: main(b0898a8)
  • pr: 02-12-feat_auto_merge_options_from_tsconfig_to_transformoption(184230b)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     71.3±0.70ms        ? ?/sec    1.03     73.2±1.04ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     92.8±0.85ms        ? ?/sec    1.01     93.7±1.07ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00    105.1±1.49ms        ? ?/sec    1.01    105.9±1.39ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     81.6±1.37ms        ? ?/sec    1.01     82.8±1.19ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    121.3±1.32ms        ? ?/sec    1.01    123.1±2.89ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.09    220.3±9.31ms        ? ?/sec    1.00    201.6±2.77ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.03    242.4±1.96ms        ? ?/sec    1.00    235.0±2.71ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    134.0±1.32ms        ? ?/sec    1.01    135.0±1.50ms        ? ?/sec
bundle/bundle@threejs                                               1.00     40.2±0.59ms        ? ?/sec    1.03     41.4±2.63ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     92.1±2.08ms        ? ?/sec    1.00     91.9±0.92ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00    105.2±2.15ms        ? ?/sec    1.03    108.1±1.47ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     50.7±0.84ms        ? ?/sec    1.00     50.8±0.30ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    429.5±4.01ms        ? ?/sec    1.00    427.9±3.76ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1074.5±5.28ms        ? ?/sec    1.00   1079.7±3.89ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01   1254.4±5.48ms        ? ?/sec    1.00   1244.4±9.88ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.01   501.5±18.21ms        ? ?/sec    1.00    497.9±3.33ms        ? ?/sec
remapping/remapping                                                 1.00     23.8±2.57ms        ? ?/sec    1.09     26.0±0.84ms        ? ?/sec
remapping/render-chunk-remapping                                    1.03     66.8±5.57ms        ? ?/sec    1.00     64.6±3.19ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     93.2±0.84ms        ? ?/sec    1.00     92.8±0.96ms        ? ?/sec
scan/scan@threejs                                                   1.01     31.4±0.84ms        ? ?/sec    1.00     31.2±1.00ms        ? ?/sec
scan/scan@threejs10x                                                1.00    313.4±4.01ms        ? ?/sec    1.00    313.2±5.44ms        ? ?/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-12-feat_auto_merge_options_from_tsconfig_to_transformoption branch from 71ddc38 to 3c47fa2 Compare February 12, 2025 14:32
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-12-feat_add_base_transform_options branch from e87cd0f to c518418 Compare February 15, 2025 07:58
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-12-feat_auto_merge_options_from_tsconfig_to_transformoption branch from 3c47fa2 to 4946f90 Compare February 15, 2025 07:58
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review February 15, 2025 08:04
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-12-feat_auto_merge_options_from_tsconfig_to_transformoption branch 3 times, most recently from 246bab4 to 334ff8e Compare February 15, 2025 08:50
@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 February 15, 2025 11:09
Base automatically changed from 02-12-feat_add_base_transform_options to main February 16, 2025 04:53
@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-12-feat_auto_merge_options_from_tsconfig_to_transformoption branch from 334ff8e to ce4976c Compare February 16, 2025 04:53
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented Feb 16, 2025

Merge activity

  • Feb 15, 11:54 PM EST: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@netlify
Copy link
Copy Markdown

netlify Bot commented Feb 16, 2025 •
edited
Loading

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 184230b
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67b188569d3d0b0008b14cce
😎 Deploy Preview https://deploy-preview-3566--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IWANABETHATGUY IWANABETHATGUY force-pushed the 02-12-feat_auto_merge_options_from_tsconfig_to_transformoption branch from ce4976c to 184230b Compare February 16, 2025 06:40
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Feb 16, 2025
Merged via the queue into main with commit 98969da Feb 16, 2025
@IWANABETHATGUY IWANABETHATGUY deleted the 02-12-feat_auto_merge_options_from_tsconfig_to_transformoption branch February 16, 2025 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Rolldown is not honouring jsxImportSource in tsconfig.json [Bug]: passes TypeScript experimental decorators as-is

2 participants

@IWANABETHATGUY @hyf0