Skip to content

fix(hash): should compute cross chunk dependecis in stable order#3524

Merged
hyf0 merged 1 commit into
mainfrom
02-08-fix_hash_should_compute_cross_chunk_dependecis_in_stable_order
Feb 8, 2025
Merged

fix(hash): should compute cross chunk dependecis in stable order#3524
hyf0 merged 1 commit into
mainfrom
02-08-fix_hash_should_compute_cross_chunk_dependecis_in_stable_order

Conversation

@hyf0

@hyf0 hyf0 commented Feb 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

I test 5 times locally and all works fine.

@hyf0 Graphite App

hyf0 commented Feb 8, 2025

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review February 8, 2025 14:41
@hyf0 hyf0 requested a review from IWANABETHATGUY February 8, 2025 14:41
@github-actions

github-actions Bot commented Feb 8, 2025

Copy link
Copy Markdown
Contributor

Benchmarks Rust

  • target: main(c34d2d4)
  • pr: 02-08-fix_hash_should_compute_cross_chunk_dependecis_in_stable_order(69bf651)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.03     74.8±1.22ms        ? ?/sec    1.00     73.0±2.41ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.03     95.9±2.36ms        ? ?/sec    1.00     93.5±2.07ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.02    108.0±2.37ms        ? ?/sec    1.00    105.5±1.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.02     82.9±1.47ms        ? ?/sec    1.00     81.0±1.48ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    122.9±1.64ms        ? ?/sec    1.00    121.5±1.22ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.05    214.7±5.33ms        ? ?/sec    1.00    205.0±4.57ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.06    254.2±9.88ms        ? ?/sec    1.00    239.4±7.69ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.02    137.0±2.53ms        ? ?/sec    1.00    134.3±1.90ms        ? ?/sec
bundle/bundle@threejs                                               1.00     41.5±1.39ms        ? ?/sec    1.00     41.4±1.21ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.01     93.1±2.60ms        ? ?/sec    1.00     92.2±1.12ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.05    111.3±2.54ms        ? ?/sec    1.00    105.7±2.46ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     51.8±1.02ms        ? ?/sec    1.01     52.1±2.05ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    428.3±5.31ms        ? ?/sec    1.03    440.7±9.23ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1061.8±9.99ms        ? ?/sec    1.01   1071.4±7.00ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.01  1252.3±11.80ms        ? ?/sec    1.00  1237.0±15.42ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00   502.1±22.36ms        ? ?/sec    1.00    500.9±4.94ms        ? ?/sec
remapping/remapping                                                 1.01     25.2±0.95ms        ? ?/sec    1.00     25.1±0.28ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     64.0±2.59ms        ? ?/sec    1.02     65.3±4.15ms        ? ?/sec
scan/scan@rome-ts                                                   1.03    101.1±1.41ms        ? ?/sec    1.00     98.6±1.28ms        ? ?/sec
scan/scan@threejs                                                   1.00     31.8±0.49ms        ? ?/sec    1.01     32.0±0.96ms        ? ?/sec
scan/scan@threejs10x                                                1.01    323.8±6.43ms        ? ?/sec    1.00    319.7±4.23ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Feb 8, 2025
Merged via the queue into main with commit 52119c7 Feb 8, 2025
@hyf0 hyf0 deleted the 02-08-fix_hash_should_compute_cross_chunk_dependecis_in_stable_order branch February 8, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: entryFileNames hash is the same despite different content

2 participants

@hyf0 @IWANABETHATGUY