Skip to content

perf: use fxhash for DashMaps#2971

Merged
hyf0 merged 6 commits intorolldown:mainfrom
sapphi-red:perf/use-fxhash-for-dashmap
Nov 28, 2024
Merged

perf: use fxhash for DashMaps#2971
hyf0 merged 6 commits intorolldown:mainfrom
sapphi-red:perf/use-fxhash-for-dashmap

Conversation

@sapphi-red
Copy link
Member

Description

Specified HashBuilder as FxHash for all DashMap / DashSet and TypedDashMap.

@netlify
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b84a6d1
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/67482f1e44c3060008c161ea

@underfin
Copy link
Contributor

Could you add a type FxDashMap<K, V> = DashMap<K, V, FxBuildHasher> to make it easy to usage.

@hyf0
Copy link
Member

hyf0 commented Nov 28, 2024

Yeah. You could a FxDashMap alias in rolldown_utils/src/dashmap.rs.

@hyf0 hyf0 enabled auto-merge November 28, 2024 08:49
@hyf0 hyf0 added this pull request to the merge queue Nov 28, 2024
Merged via the queue into rolldown:main with commit 33beb44 Nov 28, 2024
@sapphi-red sapphi-red deleted the perf/use-fxhash-for-dashmap branch November 28, 2024 09:16
Boshen pushed a commit to oxc-project/oxc that referenced this pull request Nov 28, 2024
Use `FxDashMap` instead of plain `DashMap` for browser query cache.

Inspired by rolldown/rolldown#2971.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants