Skip to content

fix(inlineDynamicImports): don't normalize inlineDynamicImports on js side#2834

Merged
hyf0 merged 1 commit intomainfrom
11-21-fix_inlinedynamicimports_don_t_normalize_inlinedynamicimports_on_js_side
Nov 21, 2024
Merged

fix(inlineDynamicImports): don't normalize inlineDynamicImports on js side#2834
hyf0 merged 1 commit intomainfrom
11-21-fix_inlinedynamicimports_don_t_normalize_inlinedynamicimports_on_js_side

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Nov 21, 2024 •
edited
Loading

Description

Fixes #2832.

#1041 need to move forward I guess.

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Nov 21, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review November 21, 2024 08:04
@netlify
Copy link
Copy Markdown

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6450b8c
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/673eece337a4600008903dac

@hyf0 hyf0 mentioned this pull request Nov 21, 2024
Closed
@hyf0 hyf0 force-pushed the 11-21-fix_inlinedynamicimports_don_t_normalize_inlinedynamicimports_on_js_side branch from 5db8459 to 6450b8c Compare November 21, 2024 08:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 21, 2024

Benchmarks Rust

  • target: main(0b8dbaa)
  • pr: 11-21-fix_inlinedynamicimports_don_t_normalize_inlinedynamicimports_on_js_side(6450b8c)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.10     69.6±2.24ms        ? ?/sec    1.00     63.4±1.19ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.11     99.6±2.66ms        ? ?/sec    1.00     90.1±2.20ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.09    112.6±3.42ms        ? ?/sec    1.00    103.8±1.18ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.09     79.5±1.31ms        ? ?/sec    1.00     72.8±1.20ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01    113.4±1.30ms        ? ?/sec    1.00    112.7±1.17ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.07    229.3±8.15ms        ? ?/sec    1.00    214.3±3.65ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.10   296.6±15.51ms        ? ?/sec    1.00    269.2±9.49ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.03    129.9±1.64ms        ? ?/sec    1.00    125.6±1.58ms        ? ?/sec
bundle/bundle@threejs                                               1.03     37.6±0.51ms        ? ?/sec    1.00     36.6±1.72ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.03     98.3±2.66ms        ? ?/sec    1.00     95.2±1.64ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.06    118.8±4.06ms        ? ?/sec    1.00    111.7±1.96ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     45.7±0.38ms        ? ?/sec    1.00     45.8±0.40ms        ? ?/sec
bundle/bundle@threejs10x                                            1.03    411.0±6.26ms        ? ?/sec    1.00    400.2±9.48ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00  1306.7±13.98ms        ? ?/sec    1.00  1304.7±15.26ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1516.7±11.55ms        ? ?/sec    1.00  1517.9±10.74ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.03   478.3±10.30ms        ? ?/sec    1.00    465.4±7.21ms        ? ?/sec
remapping/remapping                                                 1.00     27.4±0.39ms        ? ?/sec    1.04     28.4±0.11ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     76.3±1.16ms        ? ?/sec    1.02     77.5±0.97ms        ? ?/sec
scan/scan@rome-ts                                                   1.04     93.1±1.22ms        ? ?/sec    1.00     89.8±0.78ms        ? ?/sec
scan/scan@threejs                                                   1.07     29.7±2.82ms        ? ?/sec    1.00     27.7±0.30ms        ? ?/sec
scan/scan@threejs10x                                                1.01    291.9±3.52ms        ? ?/sec    1.00    290.1±4.95ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into main with commit 1ae6760 Nov 21, 2024
@hyf0 hyf0 deleted the 11-21-fix_inlinedynamicimports_don_t_normalize_inlinedynamicimports_on_js_side branch November 21, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@underfin underfin underfin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: output.inlineDynamicImports warning is always output when bundling to IIFE format

2 participants

@hyf0 @underfin