chore(pkgs/bench): move bench to packages#236
Merged
Conversation
Member
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
hyf0
commented
Nov 13, 2023
| git clone https://github.com/mrdoob/three.js.git --depth 1 ./temp/three.js | ||
| for i in {1..10}; do cp -r ./temp/three.js/src ./temp/three.js/copy$i/; done | ||
|
|
||
| # build node binding |
Member
Author
There was a problem hiding this comment.
@kazupon You could use yarn build:binding for build node binding.
I have not thought through how we unify the scripts in justfile and pakcgae.json. But let's not add extra command if existing command could achive the same goal.
9eafaec to
b91ec98
Compare
underfin
approved these changes
Nov 13, 2023
Base automatically changed from
11-13-chore_rename_rolldown/core_to_rolldown/node_
to
main
November 13, 2023 06:44
6db82fc to
efdbee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
I tend not to have many folders in root dir, this could make repo cleaner while being first seen.
Test Plan