Skip to content

chore(pkgs/bench): move bench to packages#236

Merged
hyf0 merged 2 commits into
mainfrom
11-13-chore_pkgs/bench_move_bench_to_packages_
Nov 13, 2023
Merged

chore(pkgs/bench): move bench to packages#236
hyf0 merged 2 commits into
mainfrom
11-13-chore_pkgs/bench_move_bench_to_packages_

Conversation

@hyf0

@hyf0 hyf0 commented Nov 13, 2023

Copy link
Copy Markdown
Member

Description

I tend not to have many folders in root dir, this could make repo cleaner while being first seen.

Test Plan


@hyf0

hyf0 commented Nov 13, 2023

Copy link
Copy Markdown
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

Comment thread justfile
git clone https://github.com/mrdoob/three.js.git --depth 1 ./temp/three.js
for i in {1..10}; do cp -r ./temp/three.js/src ./temp/three.js/copy$i/; done

# build node binding

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazupon You could use yarn build:binding for build node binding.

I have not thought through how we unify the scripts in justfile and pakcgae.json. But let's not add extra command if existing command could achive the same goal.

@hyf0 hyf0 force-pushed the 11-13-chore_pkgs/bench_move_bench_to_packages_ branch from 9eafaec to b91ec98 Compare November 13, 2023 04:12
@hyf0 hyf0 requested a review from houyunlu November 13, 2023 04:14
@hyf0

hyf0 commented Nov 13, 2023

Copy link
Copy Markdown
Member Author

Merge activity

  • Nov 13, 1:44 AM: @hyf0 started a stack merge that includes this pull request via Graphite.
  • Nov 13, 1:44 AM: Graphite rebased this pull request as part of a merge.
  • Nov 13, 1:45 AM: @hyf0 merged this pull request with Graphite.

Base automatically changed from 11-13-chore_rename_rolldown/core_to_rolldown/node_ to main November 13, 2023 06:44
@hyf0 hyf0 force-pushed the 11-13-chore_pkgs/bench_move_bench_to_packages_ branch from 6db82fc to efdbee1 Compare November 13, 2023 06:44
@hyf0 hyf0 merged commit afb631d into main Nov 13, 2023
@hyf0 hyf0 deleted the 11-13-chore_pkgs/bench_move_bench_to_packages_ branch November 13, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants