Skip to content

fix(iife): deconflict inject external symbol#2328

Merged
underfin merged 1 commit intomainfrom
deconflict-iife-external-symbol
Sep 26, 2024
Merged

fix(iife): deconflict inject external symbol#2328
underfin merged 1 commit intomainfrom
deconflict-iife-external-symbol

Conversation

@underfin
Copy link
Copy Markdown
Contributor

Description

close #1623

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 26, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 959133b
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66f4cd424339430008343cc3

@github-actions
Copy link
Copy Markdown
Contributor

Benchmarks Rust

group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     55.6±0.40ms        ? ?/sec    1.00     55.8±0.41ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     80.2±0.91ms        ? ?/sec    1.00     80.5±0.48ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     96.1±0.70ms        ? ?/sec    1.01     96.7±0.85ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     63.6±0.45ms        ? ?/sec    1.01     64.2±0.36ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    102.7±0.93ms        ? ?/sec    1.00    102.6±0.59ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    182.4±1.46ms        ? ?/sec    1.01    183.8±1.64ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    227.4±2.16ms        ? ?/sec    1.00    226.9±4.83ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    117.8±0.82ms        ? ?/sec    1.00    118.0±0.86ms        ? ?/sec
bundle/bundle@threejs                                               1.02     36.1±1.64ms        ? ?/sec    1.00     35.2±0.45ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     82.9±1.67ms        ? ?/sec    1.01     83.3±1.19ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     99.4±1.89ms        ? ?/sec    1.02    101.2±1.81ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     43.6±0.32ms        ? ?/sec    1.00     43.8±0.18ms        ? ?/sec
bundle/bundle@threejs10x                                            1.01    365.0±2.28ms        ? ?/sec    1.00    362.5±1.55ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   1007.0±8.41ms        ? ?/sec    1.00   1007.6±4.87ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00  1268.9±10.29ms        ? ?/sec    1.01  1281.2±13.01ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    432.3±2.56ms        ? ?/sec    1.00    432.6±3.60ms        ? ?/sec
remapping/remapping                                                 1.05     34.0±2.96ms        ? ?/sec    1.00     32.4±0.15ms        ? ?/sec
remapping/render-chunk-remapping                                    1.02     83.8±0.44ms        ? ?/sec    1.00     82.5±0.37ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     84.0±0.74ms        ? ?/sec    1.00     83.5±0.83ms        ? ?/sec
scan/scan@threejs                                                   1.00     25.7±0.08ms        ? ?/sec    1.01     25.9±0.80ms        ? ?/sec
scan/scan@threejs10x                                                1.01    265.3±2.03ms        ? ?/sec    1.00    263.9±2.36ms        ? ?/sec

@underfin underfin added this pull request to the merge queue Sep 26, 2024
Merged via the queue into main with commit 7214af6 Sep 26, 2024
@underfin underfin deleted the deconflict-iife-external-symbol branch September 26, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gracefully handle external modules in iife format

2 participants