How about we just keep generating imports from external modules

import ext from 'ext'
import { a } from 'ext'
console.log(ext, a, require('ext'))

become

import ext from 'ext'
import { a } from 'ext'

(function() {
  console.log(ext, a, require('ext'))
})()

Still follows the shits in, shits out principle.

esbuild's output

https://hyrious.me/esbuild-repl/?version=0.23.0&b=e%00entry.js%00import+ext+from+%27ext%27%0Aimport+%7B+a+%7D+from+%27ext%27%0Aconsole.log%28ext%2C+a%2C+require%28%27ext%27%29%29&o=--bundle+--format%3Diife+--external%3Aext+--outdir%3Ddist

(() => {
  var __create = Object.create;
  var __defProp = Object.defineProperty;
  var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
  var __getOwnPropNames = Object.getOwnPropertyNames;
  var __getProtoOf = Object.getPrototypeOf;
  var __hasOwnProp = Object.prototype.hasOwnProperty;
  var __require = /* @__PURE__ */ ((x) => typeof require !== "undefined" ? require : typeof Proxy !== "undefined" ? new Proxy(x, {
    get: (a2, b) => (typeof require !== "undefined" ? require : a2)[b]
  }) : x)(function(x) {
    if (typeof require !== "undefined") return require.apply(this, arguments);
    throw Error('Dynamic require of "' + x + '" is not supported');
  });
  var __copyProps = (to, from, except, desc) => {
    if (from && typeof from === "object" || typeof from === "function") {
      for (let key of __getOwnPropNames(from))
        if (!__hasOwnProp.call(to, key) && key !== except)
          __defProp(to, key, { get: () => from[key], enumerable: !(desc = __getOwnPropDesc(from, key)) || desc.enumerable });
    }
    return to;
  };
  var __toESM = (mod, isNodeMode, target) => (target = mod != null ? __create(__getProtoOf(mod)) : {}, __copyProps(
    // If the importer is in node compatibility mode or this is not an ESM
    // file that has been converted to a CommonJS file using a Babel-
    // compatible transform (i.e. "__esModule" has not been set), then set
    // "default" to the CommonJS "module.exports" for node compatibility.
    isNodeMode || !mod || !mod.__esModule ? __defProp(target, "default", { value: mod, enumerable: true }) : target,
    mod
  ));

  // entry.js
  var import_ext = __toESM(__require("ext"));
  var import_ext2 = __require("ext");
  console.log(import_ext.default, import_ext2.a, __require("ext"));
})();

rollup's output

https://rollupjs.org/repl/?version=4.18.1&shareable=JTdCJTIyZXhhbXBsZSUyMiUzQW51bGwlMkMlMjJtb2R1bGVzJTIyJTNBJTVCJTdCJTIyY29kZSUyMiUzQSUyMmltcG9ydCUyMGV4dCUyMGZyb20lMjAnZXh0JyU1Q25pbXBvcnQlMjAlN0IlMjBhJTIwJTdEJTIwZnJvbSUyMCdleHQnJTVDbmNvbnNvbGUubG9nKGV4dCUyQyUyMGElMkMlMjByZXF1aXJlKCdleHQnKSklMjIlMkMlMjJpc0VudHJ5JTIyJTNBdHJ1ZSUyQyUyMm5hbWUlMjIlM0ElMjJtYWluLmpzJTIyJTdEJTVEJTJDJTIyb3B0aW9ucyUyMiUzQSU3QiUyMm91dHB1dCUyMiUzQSU3QiUyMmZvcm1hdCUyMiUzQSUyMmlpZmUlMjIlMkMlMjJnbG9iYWxzJTIyJTNBJTdCJTdEJTdEJTJDJTIydHJlZXNoYWtlJTIyJTNBdHJ1ZSU3RCU3RA==

(function (ext) {
	'use strict';

	console.log(ext, ext.a, require('ext'));

})(ext);

Gracefully handle external modules in iife format #1623

Description

Metadata

Metadata

Assignees

Labels

Type

Fields

Projects

Milestone

Relationships

Development

Issue actions