fix(node/rolldown): mark all tsfn as weak to avoid long exit time#2135
Merged
fix(node/rolldown): mark all tsfn as weak to avoid long exit time#2135
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
Member
|
I think this did not solve the problem, <DIR>/index.js chunk │ size: 222.05 kB
✔ Finished in 153.65 ms
________________________________________________________
Executed in 8.41 secs fish external
usr time 581.94 millis 617.00 micros 581.33 millis
sys time 148.63 millis 189.00 micros 148.44 millishere is the result in local computer, maybe this is not the right timing to remove the hacky |
process.exit(0)
Member
Author
|
@IWANABETHATGUY Could you try it again with new commits? |
IWANABETHATGUY
approved these changes
Sep 3, 2024
Contributor
Benchmarks Rust |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notice that this will break the implementation of
ParallelPlugindue to worker doesn't support creating weak tsfn #985 (comment).