Skip to content

feat(treeshaking): only reference __reExport if needed#1987

Merged
hyf0 merged 1 commit intomainfrom
08-15-feat_treeshaking_only_reference___reexport_if_needed
Aug 15, 2024
Merged

feat(treeshaking): only reference __reExport if needed#1987
hyf0 merged 1 commit intomainfrom
08-15-feat_treeshaking_only_reference___reexport_if_needed

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Aug 15, 2024

Description

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Aug 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@hyf0 hyf0 marked this pull request as ready for review August 15, 2024 09:13
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 15, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 20cf42d
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66bdc6abcc95460009ddee41

@hyf0 hyf0 enabled auto-merge August 15, 2024 09:20
@hyf0 hyf0 added this pull request to the merge queue Aug 15, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 15, 2024

Benchmarks Rust

  • target: main(c820678)
  • pr: 08-15-feat_treeshaking_only_reference___reexport_if_needed(20cf42d)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     52.3±0.95ms        ? ?/sec    1.00     52.2±0.68ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     74.9±0.89ms        ? ?/sec    1.02     76.2±1.47ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     91.8±2.05ms        ? ?/sec    1.01     92.3±1.43ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     60.0±1.23ms        ? ?/sec    1.01     60.5±0.76ms        ? ?/sec
bundle/bundle@rome-ts                                               1.00    100.0±1.05ms        ? ?/sec    1.01    101.2±1.06ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    178.7±2.29ms        ? ?/sec    1.01    180.4±2.91ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.00    219.7±2.29ms        ? ?/sec    1.01    222.9±6.32ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    116.8±1.35ms        ? ?/sec    1.00    117.0±1.95ms        ? ?/sec
bundle/bundle@threejs                                               1.00     36.2±0.35ms        ? ?/sec    1.00     36.3±1.06ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     81.3±1.27ms        ? ?/sec    1.02     83.2±1.42ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     98.4±0.81ms        ? ?/sec    1.01     99.1±2.04ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     45.7±0.84ms        ? ?/sec    1.03     47.0±0.50ms        ? ?/sec
bundle/bundle@threejs10x                                            1.02    388.3±3.50ms        ? ?/sec    1.00    380.4±1.92ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.01   998.9±10.51ms        ? ?/sec    1.00    990.4±6.54ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.02  1245.2±11.92ms        ? ?/sec    1.00  1224.5±10.87ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    456.2±5.85ms        ? ?/sec    1.00    458.0±2.92ms        ? ?/sec
remapping/remapping                                                 1.00     31.7±0.31ms        ? ?/sec    1.03     32.5±0.13ms        ? ?/sec
remapping/render-chunk-remapping                                    1.02     83.5±0.52ms        ? ?/sec    1.00     81.7±0.35ms        ? ?/sec
scan/scan@rome-ts                                                   1.01     82.1±0.60ms        ? ?/sec    1.00     81.2±1.45ms        ? ?/sec
scan/scan@threejs                                                   1.01     29.0±0.82ms        ? ?/sec    1.00     28.7±0.14ms        ? ?/sec
scan/scan@threejs10x                                                1.01    294.0±6.38ms        ? ?/sec    1.00    292.0±1.81ms        ? ?/sec

Merged via the queue into main with commit 4cac925 Aug 15, 2024
@hyf0 hyf0 deleted the 08-15-feat_treeshaking_only_reference___reexport_if_needed branch August 15, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @IWANABETHATGUY