Skip to content

feat: support OutputOptions#externalLiveBindings#1979

Merged
hyf0 merged 1 commit intomainfrom
08-14-feat_support_outputoptions_externallivebindings_
Aug 14, 2024
Merged

feat: support OutputOptions#externalLiveBindings#1979
hyf0 merged 1 commit intomainfrom
08-14-feat_support_outputoptions_externallivebindings_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Aug 14, 2024

Description

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Aug 14, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 14, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 7c290fc
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66bc58f09baec300080ccdf0

@hyf0 hyf0 marked this pull request as ready for review August 14, 2024 07:12
@hyf0 hyf0 force-pushed the 08-14-feat_support_outputoptions_externallivebindings_ branch from a494295 to 7c290fc Compare August 14, 2024 07:12
7086cmd
7086cmd reviewed Aug 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@7086cmd 7086cmd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you included the options to normalize-output-options.ts and normalized-output-options.ts?

@hyf0 hyf0 enabled auto-merge August 14, 2024 07:31
@hyf0
Copy link
Copy Markdown
Member Author

hyf0 commented Aug 14, 2024

Have you included the options to normalize-output-options.ts and normalized-output-options.ts?

Yeah. I forgot this part. But #1041 is planned, we gonna move the normalization step to rust side.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 14, 2024

Benchmarks Rust

  • target: main(6d4ef7e)
  • pr: 08-14-feat_support_outputoptions_externallivebindings_(7c290fc)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     48.4±0.71ms        ? ?/sec    1.01     48.9±0.84ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.01     72.8±1.17ms        ? ?/sec    1.00     72.1±3.04ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.01     87.7±1.40ms        ? ?/sec    1.00     87.0±1.35ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     55.9±0.83ms        ? ?/sec    1.01     56.3±1.32ms        ? ?/sec
bundle/bundle@rome-ts                                               1.03     97.7±1.79ms        ? ?/sec    1.00     94.9±1.57ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    170.8±3.85ms        ? ?/sec    1.00    170.0±4.56ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.01    207.5±2.35ms        ? ?/sec    1.00    204.9±3.31ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    111.1±1.51ms        ? ?/sec    1.01    112.7±2.04ms        ? ?/sec
bundle/bundle@threejs                                               1.00     34.1±0.59ms        ? ?/sec    1.00     34.2±1.20ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     76.4±2.52ms        ? ?/sec    1.02     78.1±1.07ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.02     93.2±2.50ms        ? ?/sec    1.00     91.3±1.94ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.00     43.3±0.39ms        ? ?/sec    1.00     43.1±0.68ms        ? ?/sec
bundle/bundle@threejs10x                                            1.02    375.7±7.02ms        ? ?/sec    1.00    367.4±8.55ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00   933.4±16.91ms        ? ?/sec    1.00    935.2±8.47ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.02  1167.0±21.50ms        ? ?/sec    1.00  1149.2±15.15ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.02    439.9±7.47ms        ? ?/sec    1.00    430.4±4.81ms        ? ?/sec
remapping/remapping                                                 1.00     29.4±0.69ms        ? ?/sec    1.06     31.1±0.41ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     74.9±1.04ms        ? ?/sec    1.02     76.5±1.29ms        ? ?/sec
scan/scan@rome-ts                                                   1.02     77.8±1.28ms        ? ?/sec    1.00     76.1±1.13ms        ? ?/sec
scan/scan@threejs                                                   1.00     27.0±0.33ms        ? ?/sec    1.02     27.4±0.79ms        ? ?/sec
scan/scan@threejs10x                                                1.01    276.2±6.25ms        ? ?/sec    1.00    274.7±2.09ms        ? ?/sec

@hyf0 hyf0 self-assigned this Aug 14, 2024
@hyf0 hyf0 added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit cc41c94 Aug 14, 2024
@hyf0 hyf0 deleted the 08-14-feat_support_outputoptions_externallivebindings_ branch August 14, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

+1 more reviewer

@7086cmd 7086cmd 7086cmd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@hyf0 hyf0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hyf0 @7086cmd