fix(node/plugin): ensure order for generateBundle and writeBundle hooks#1913
Merged
fix(node/plugin): ensure order for generateBundle and writeBundle hooks#1913
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
hyf0
approved these changes
Aug 9, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
### Description I added a fake "deprecated" type to reduce a churn due to ecosystem failing by ts error (see https://github.com/vitejs/vite-ecosystem-ci/blob/rolldown-vite/README-temp.md and also my plugin hit by this too hi-ogawa/vite-plugins#673). As I wrote in #3337 (comment), Rolldown's plugin hook always works same as rollup's `sequential: true` and this behavior is likely good for the ecosystem since people mostly needed `sequential: true` to avoid running `writeBundle` hooks in parallel on rollup. I think the test added in #1913 already verifies such sequential behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description