Skip to content

feat(node/rolldown): support define functionality#1891

Merged
hyf0 merged 1 commit intomainfrom
08-07-feat_node_rolldown_add_inputoptions_define_
Aug 7, 2024
Merged

feat(node/rolldown): support define functionality#1891
hyf0 merged 1 commit intomainfrom
08-07-feat_node_rolldown_add_inputoptions_define_

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Aug 7, 2024 •
edited
Loading

Description

Closes #186.

So far the target expr could only be identifier or member expression, but the replacement could be any expr.

@hyf0 hyf0 marked this pull request as ready for review August 7, 2024 09:01
@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Aug 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 7, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 6df983c
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66b338026b96c200086f1aad

@hyf0 hyf0 force-pushed the 08-07-feat_node_rolldown_add_inputoptions_define_ branch from a041c46 to 6df983c Compare August 7, 2024 09:01
@hyf0 hyf0 changed the title feat(node/rolldown) add InputOptions#define feat(rust): support define functionality Aug 7, 2024
@hyf0 hyf0 changed the title feat(rust): support define functionality feat(node/rolldown): support define functionality Aug 7, 2024
@hyf0 hyf0 enabled auto-merge August 7, 2024 09:05
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 7, 2024

Benchmarks Rust

  • target: main(03f6dc9)
  • pr: 08-07-feat_node_rolldown_add_inputoptions_define_(6df983c)
group                                                               pr                                     target
-----                                                               --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol                     1.00     47.3±0.90ms        ? ?/sec    1.01     47.7±1.18ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify              1.00     64.9±0.81ms        ? ?/sec    1.03     66.9±1.39ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-minify-sourcemap    1.00     81.6±0.66ms        ? ?/sec    1.01     82.6±1.27ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap           1.00     55.5±1.34ms        ? ?/sec    1.02     56.5±1.60ms        ? ?/sec
bundle/bundle@rome-ts                                               1.01     91.7±2.20ms        ? ?/sec    1.00     90.9±0.93ms        ? ?/sec
bundle/bundle@rome-ts-minify                                        1.00    151.4±2.72ms        ? ?/sec    1.01    153.1±2.15ms        ? ?/sec
bundle/bundle@rome-ts-minify-sourcemap                              1.01    193.1±3.49ms        ? ?/sec    1.00    191.7±1.95ms        ? ?/sec
bundle/bundle@rome-ts-sourcemap                                     1.00    107.0±1.07ms        ? ?/sec    1.00    107.0±1.58ms        ? ?/sec
bundle/bundle@threejs                                               1.01     27.4±1.38ms        ? ?/sec    1.00     27.0±0.59ms        ? ?/sec
bundle/bundle@threejs-minify                                        1.00     64.0±1.86ms        ? ?/sec    1.01     64.6±0.96ms        ? ?/sec
bundle/bundle@threejs-minify-sourcemap                              1.00     79.7±1.24ms        ? ?/sec    1.02     81.0±1.41ms        ? ?/sec
bundle/bundle@threejs-sourcemap                                     1.02     36.8±0.37ms        ? ?/sec    1.00     36.2±0.32ms        ? ?/sec
bundle/bundle@threejs10x                                            1.00    302.2±2.38ms        ? ?/sec    1.01    305.0±2.98ms        ? ?/sec
bundle/bundle@threejs10x-minify                                     1.00    750.6±5.29ms        ? ?/sec    1.01   755.6±12.64ms        ? ?/sec
bundle/bundle@threejs10x-minify-sourcemap                           1.00   980.0±10.31ms        ? ?/sec    1.01    985.2±9.31ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                                  1.00    368.3±2.83ms        ? ?/sec    1.01    370.3±2.71ms        ? ?/sec
remapping/remapping                                                 1.00     32.1±0.17ms        ? ?/sec    1.01     32.5±0.14ms        ? ?/sec
remapping/render-chunk-remapping                                    1.00     82.6±0.48ms        ? ?/sec    1.01     83.6±0.51ms        ? ?/sec
scan/scan@rome-ts                                                   1.00     72.3±0.69ms        ? ?/sec    1.00     72.4±0.87ms        ? ?/sec
scan/scan@threejs                                                   1.01     20.3±1.01ms        ? ?/sec    1.00     20.1±0.29ms        ? ?/sec
scan/scan@threejs10x                                                1.00    208.0±1.42ms        ? ?/sec    1.00    208.1±1.44ms        ? ?/sec

@hyf0 hyf0 added this pull request to the merge queue Aug 7, 2024
Merged via the queue into main with commit 43f6f22 Aug 7, 2024
@hyf0 hyf0 deleted the 08-07-feat_node_rolldown_add_inputoptions_define_ branch August 7, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

How to support define options.

2 participants

@hyf0 @IWANABETHATGUY