Skip to content

feat: support output.footer in plugins.#1713

Merged
underfin merged 8 commits intorolldown:mainfrom
7086cmd:feature/add-footer
Jul 25, 2024
Merged

feat: support output.footer in plugins.#1713
underfin merged 8 commits intorolldown:mainfrom
7086cmd:feature/add-footer

Conversation

@7086cmd
Copy link
Copy Markdown
Contributor

@7086cmd 7086cmd commented Jul 24, 2024 •
edited
Loading

resolves #1702.
Thanks to @komyg for your contribution! This PR involves some test errors. Check it out here.

@7086cmd 7086cmd changed the title feat: support output.footer in plugins. (continue here in #1702) feat: support output.footer in plugins. (continue here in #1702) Jul 24, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Jul 24, 2024 •
edited
Loading

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 5188c66
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66a1c36cb19d5f0008357b70

@underfin underfin enabled auto-merge July 25, 2024 03:15
@underfin underfin disabled auto-merge July 25, 2024 03:17
@7086cmd 7086cmd changed the title feat: support output.footer in plugins. (continue here in #1702) feat: support output.footer in plugins. Jul 25, 2024
@underfin underfin enabled auto-merge July 25, 2024 03:20
@underfin
Copy link
Copy Markdown
Contributor

underfin commented Jul 25, 2024

Thanks you. I will closed #1702

@underfin underfin added this pull request to the merge queue Jul 25, 2024
Merged via the queue into rolldown:main with commit 536d5f7 Jul 25, 2024
@7086cmd 7086cmd deleted the feature/add-footer branch July 25, 2024 05:06
This was referenced Jul 27, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 28, 2024
@7086cmd
feat: support intro and outro in plugins. (#1763)
b15d8c5 
#### Contents

1. **Code Optimization:**
   - Refined types like `HookBannerArgs` to `HookInjectionArgs`, etc.
   - **macros in #1755 are removed now**.

2. **Plugin Enhancements:**
- Added support for `intro` and `outro` in plugins, using #1713 as a
reference example.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@underfin underfin underfin approved these changes

@komyg komyg komyg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@7086cmd @underfin @komyg