Skip to content

refactor(rust/bench): add rome-ts and prepare test benchmark input#1410

Merged
hyf0 merged 1 commit intomainfrom
06-18-refactor_rust_bench_add_rome-ts_and_prepare_test_benchmark_input
Jun 18, 2024
Merged

refactor(rust/bench): add rome-ts and prepare test benchmark input#1410
hyf0 merged 1 commit intomainfrom
06-18-refactor_rust_bench_add_rome-ts_and_prepare_test_benchmark_input

Conversation

@hyf0
Copy link
Copy Markdown
Member

@hyf0 hyf0 commented Jun 18, 2024

Description

@hyf0 Graphite App
Copy link
Copy Markdown
Member Author

hyf0 commented Jun 18, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hyf0 and the rest of your teammates on Graphite Graphite

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 18, 2024

✅ Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 73045a3
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/6671a61be788110008b5a34d

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.

Project coverage is 84.99%. Comparing base (f084e69) to head (73045a3).

Files Patch % Lines
crates/rolldown_testing/src/utils.rs 0.00% 26 Missing ⚠️
...own_testing/src/bundler_options_presets/threejs.rs 0.00% 20 Missing ⚠️
...own_testing/src/bundler_options_presets/rome_ts.rs 0.00% 19 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
- Coverage   85.74%   84.99%   -0.76%     
==========================================
  Files         146      149       +3     
  Lines        7331     7396      +65     
==========================================
  Hits         6286     6286              
- Misses       1045     1110      +65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 18, 2024

Benchmarks Rust

  • target: main(f084e69)
  • pr: 06-18-refactor_rust_bench_add_rome-ts_and_prepare_test_benchmark_input(73045a3)
group                                      pr                                     target
-----                                      --                                     ------
bundle/bundle@rome-ts                      1.00    104.2±1.85ms        ? ?/sec  
bundle/bundle@rome-ts-sourcemap            1.00    124.4±1.32ms        ? ?/sec  
bundle/bundle@threejs                      1.00     29.3±1.29ms        ? ?/sec  
bundle/bundle@threejs-sourcemap            1.00     35.6±0.73ms        ? ?/sec  
bundle/bundle@threejs10x                   1.00    315.4±9.74ms        ? ?/sec  
bundle/bundle@threejs10x-sourcemap         1.00    421.8±7.57ms        ? ?/sec  
rolldown benchmark/threejs-bundle                                                 1.00     30.3±0.69ms        ? ?/sec
rolldown benchmark/threejs-scan                                                   1.00     22.5±0.67ms        ? ?/sec
rolldown benchmark/threejs-sourcemap                                              1.00     40.3±0.52ms        ? ?/sec
rolldown benchmark/threejs10x-bundle                                              1.00    328.6±5.56ms        ? ?/sec
rolldown benchmark/threejs10x-scan                                                1.00    215.2±2.04ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap                                           1.00    448.0±8.59ms        ? ?/sec
scan/scan@rome-ts                          1.00     84.9±0.86ms        ? ?/sec  
scan/scan@rome-ts-sourcemap                1.00     84.1±0.78ms        ? ?/sec  
scan/scan@threejs                          1.00     22.8±1.13ms        ? ?/sec  
scan/scan@threejs-sourcemap                1.00     21.9±0.31ms        ? ?/sec  
scan/scan@threejs10x                       1.00    212.7±1.95ms        ? ?/sec  
scan/scan@threejs10x-sourcemap             1.00    213.6±3.56ms        ? ?/sec

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jun 18, 2024

CodSpeed Performance Report

Merging #1410 will create unknown performance changes

Comparing 06-18-refactor_rust_bench_add_rome-ts_and_prepare_test_benchmark_input (73045a3) with main (f084e69)

Summary

🆕 12 new benchmarks
⁉️ 6 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main 06-18-refactor_rust_bench_add_rome-ts_and_prepare_test_benchmark_input Change
🆕 bundle@rome-ts N/A 550.2 ms N/A
🆕 bundle@rome-ts-sourcemap N/A 695.7 ms N/A
🆕 bundle@threejs N/A 165.3 ms N/A
🆕 bundle@threejs-sourcemap N/A 226.7 ms N/A
🆕 bundle@threejs10x N/A 1.8 s N/A
🆕 bundle@threejs10x-sourcemap N/A 2.4 s N/A
🆕 scan@rome-ts N/A 469.5 ms N/A
🆕 scan@rome-ts-sourcemap N/A 469.8 ms N/A
🆕 scan@threejs N/A 126.7 ms N/A
🆕 scan@threejs-sourcemap N/A 126.6 ms N/A
🆕 scan@threejs10x N/A 1.3 s N/A
🆕 scan@threejs10x-sourcemap N/A 1.3 s N/A
⁉️ threejs-bundle 165.6 ms N/A N/A
⁉️ threejs-scan 126.3 ms N/A N/A
⁉️ threejs-sourcemap 227.9 ms N/A N/A
⁉️ threejs10x-bundle 1.8 s N/A N/A
⁉️ threejs10x-scan 1.3 s N/A N/A
⁉️ threejs10x-sourcemap 2.4 s N/A N/A

@hyf0 hyf0 merged commit fc7b9c6 into main Jun 18, 2024
@hyf0 hyf0 deleted the 06-18-refactor_rust_bench_add_rome-ts_and_prepare_test_benchmark_input branch June 18, 2024 15:54
@hyf0 hyf0 mentioned this pull request Jun 24, 2024
Closed
@Boshen Boshen mentioned this pull request Mar 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hyf0