chore(tests/rust): enable test cases.#1154
Merged
Merged
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
underfin
approved these changes
May 18, 2024
shulaoda
added a commit
that referenced
this pull request
Jun 11, 2026
…#9714) ## What Corrects the `tsconfig` auto-discovery documentation to match how Rolldown actually resolves `tsconfig.json` since v1.1.0. ## Why The v1.1.0 release notes covered the in-config reference changes (oxc-resolver #1151 reference priority, #1198 allowJs) but omitted [oxc-resolver #1154](oxc-project/oxc-resolver#1154) ("walk past a tsconfig that doesn't claim the file"), which shipped in oxc_resolver v11.19.2 and is part of the 11.19.1 -> 11.21.0 upgrade. As a result the docs still described the old behavior: - "find the nearest tsconfig.json" - "if no referenced project includes the file, fall back to the root tsconfig" Both are inaccurate now. `find_tsconfig_auto` walks up ancestor directories, uses the first tsconfig that owns the file (its `files`/`include`/`exclude`, or a matching `references` entry), and falls back to the outermost (topmost) tsconfig when nothing claims it. This matches TypeScript 6.0 tsserver. A solution-style root (`files: []` plus only `references`) never claims files on its own, so resolution continues upward unless one of its references matches. ## Changes - Rewrite the auto-discovery paragraph: upward, ownership-based search with topmost fallback instead of "nearest". - Fix the references paragraph: root's own `include` vs. a solution-style root, first matching reference wins, per-project `allowJs`. - Drop the "(similar to Vite)" qualifier; the semantics follow TypeScript, not Vite. - Add a `::: warning` callout flagging the v1.1.0 behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description