Skip to content

chore(tests/rust): enable test cases.#1154

Merged
underfin merged 2 commits into
rolldown:mainfrom
Cecil0o0:chore/test-rust
May 18, 2024
Merged

chore(tests/rust): enable test cases.#1154
underfin merged 2 commits into
rolldown:mainfrom
Cecil0o0:chore/test-rust

Conversation

@Cecil0o0

Copy link
Copy Markdown
Contributor

Description

@netlify

netlify Bot commented May 18, 2024

Copy link
Copy Markdown

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit b7d10ff
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/66488a9f9673660008882fc6

@underfin underfin added this pull request to the merge queue May 18, 2024
Merged via the queue into rolldown:main with commit f708156 May 18, 2024
shulaoda added a commit that referenced this pull request Jun 11, 2026
…#9714)

## What

Corrects the `tsconfig` auto-discovery documentation to match how Rolldown actually resolves `tsconfig.json` since v1.1.0.

## Why

The v1.1.0 release notes covered the in-config reference changes (oxc-resolver #1151 reference priority, #1198 allowJs) but omitted [oxc-resolver #1154](oxc-project/oxc-resolver#1154) ("walk past a tsconfig that doesn't claim the file"), which shipped in oxc_resolver v11.19.2 and is part of the 11.19.1 -> 11.21.0 upgrade.

As a result the docs still described the old behavior:

- "find the nearest tsconfig.json"
- "if no referenced project includes the file, fall back to the root tsconfig"

Both are inaccurate now. `find_tsconfig_auto` walks up ancestor directories, uses the first tsconfig that owns the file (its `files`/`include`/`exclude`, or a matching `references` entry), and falls back to the outermost (topmost) tsconfig when nothing claims it. This matches TypeScript 6.0 tsserver. A solution-style root (`files: []` plus only `references`) never claims files on its own, so resolution continues upward unless one of its references matches.

## Changes

- Rewrite the auto-discovery paragraph: upward, ownership-based search with topmost fallback instead of "nearest".
- Fix the references paragraph: root's own `include` vs. a solution-style root, first matching reference wins, per-project `allowJs`.
- Drop the "(similar to Vite)" qualifier; the semantics follow TypeScript, not Vite.
- Add a `::: warning` callout flagging the v1.1.0 behavior change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants