feat: add arm64 image by shyim · Pull Request #218 · rojopolis/spellcheck-github-actions

shyim · 2024-10-17T08:34:40Z

I am trying to run the same image locally, to see errors directly locally. BUT it has only amd64 so it's slow as hell on mac.

Before: 7m20s
Now: 23s

After merge a new docker image will appear:

ghcr.io/rojopolis/spellcheck-github-actions:master on GitHub. Open the package on the right side and change visiblity to public

After that change in action.yml it to: ghcr.io/rojopolis/spellcheck-github-actions:0.44.0 and tag only a 0.44.0 and wait for pipeline finish. When pipeline finished, create a release for GitHub Action Marketplace

mitelg · 2024-10-17T08:45:47Z

duplicate of #108 ?

.github/workflows/docker-build.yml

jonasbn

Hi @shyim

This looks great. I have added some comments and requests for changes. And I have some questions in regard to the tag part.

Thank you

jonasbn · 2025-03-29T10:27:42Z

closes #193

jonasbn · 2025-03-29T10:30:44Z

@mitelg it seems to be related to #108 and there are overlaps. When this PR is merged, I will evaluate how we get the build and release processed to be completely automatic and we can close #108 also.

jonasbn

Hi @shyim

This is approved

* feat: add arm64 image * ci: pin actions * ci: add sha

* added hunspel with en, de, es and fr dictionaries, update docs * added russian and ukranian dicts, update docs * updated os version in packages links * fixed spelling * fixed entrypoint * Bump python from 3.13.0-slim-bookworm to 3.13.1-slim-bookworm Bumps python from 3.13.0-slim-bookworm to 3.13.1-slim-bookworm. --- updated-dependencies: - dependency-name: python dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Preparing release 0.46.0, update to Docker base image * Bump nosborn/github-action-markdown-cli from 3.3.0 to 3.4.0 Bumps [nosborn/github-action-markdown-cli](https://github.com/nosborn/github-action-markdown-cli) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/nosborn/github-action-markdown-cli/releases) - [Commits](nosborn/github-action-markdown-cli@v3.3.0...v3.4.0) --- updated-dependencies: - dependency-name: nosborn/github-action-markdown-cli dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump python from 3.13.1-slim-bookworm to 3.13.2-slim-bookworm Bumps python from 3.13.1-slim-bookworm to 3.13.2-slim-bookworm. --- updated-dependencies: - dependency-name: python dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Preparing release 0.47.0 * add tool versions (#234) Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> * feat: add arm64 image (#218) * feat: add arm64 image * ci: pin actions * ci: add sha * ci: fix default branch name (#235) * Added hunspell version output to entry point * Did some testing, added more output to entrypoint, parameter specification in action.yml and some documentation --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: jonasbn <jonasbn@gmail.com> Co-authored-by: Brooke Hamilton <45323234+brooke-hamilton@users.noreply.github.com> Co-authored-by: Shyim <github@shyim.de> Co-authored-by: Jonas Brømsø <jonasbn@users.noreply.github.com>

feat: add arm64 image

3328a26

jonasbn self-requested a review October 27, 2024 13:30

jonasbn reviewed Mar 29, 2025

View reviewed changes