handle field names of Revelation entry types other than Generic#82
Merged
roddhjav merged 3 commits intoroddhjav:masterfrom Apr 16, 2020
Merged
handle field names of Revelation entry types other than Generic#82roddhjav merged 3 commits intoroddhjav:masterfrom
roddhjav merged 3 commits intoroddhjav:masterfrom
Conversation
Owner
|
Thank (again) a lot for this PR. This is a nice addition to the revelation importer and I will merge it. However, you need to fix the tests first. You cannot change the file Alternatively, to quickly and easily test your new data, you can create a new test for it in
|
Contributor
Author
|
Besides fixing the test-suite, I meanwhile used a pass-import version with these changes with real world data, successfully import 541 passwords from Revelation into pass. 😄 |
roddhjav
added a commit
that referenced
this pull request
Apr 16, 2020
Pull request #82 adapted to v3 from https://github.com/elho/pass-import/tree/revelation-update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-ancrient versions of Revelation do support various types of password entries, each having a different subset of fields. There is both fields with additional information as well as fields for the same things with different names (e.g. code or pin what essetially is the password).
This change:
--allwould result in--all) which contains what looks like epoch time stamp of last update - if wanted by some users, it should be handled properly, as it is, its of little use and high annoyance