Skip to content

fix: improperly quoted tags values in 1password.1pif test asset#209

Merged
roddhjav merged 2 commits intoroddhjav:masterfrom
davidandreoletti:master
Jan 25, 2024
Merged

fix: improperly quoted tags values in 1password.1pif test asset#209
roddhjav merged 2 commits intoroddhjav:masterfrom
davidandreoletti:master

Conversation

@davidandreoletti
Copy link
Copy Markdown
Contributor

@davidandreoletti davidandreoletti commented Jan 25, 2024

fix: improperly quoted tags values in 1password.1pif test asset #209

Values were single quoted instead of double quoted.

doc: filter dependency for pip based installs

self explanatory.

PS: Thank for conditional test runs code to reduce the noise.

@davidandreoletti
Copy link
Copy Markdown
Contributor Author

@roddhjav There you go.

@davidandreoletti
Copy link
Copy Markdown
Contributor Author

What's the most likely time window for the next release ?

@roddhjav
Copy link
Copy Markdown
Owner

Nice, thanks a lot. Merged!

Next release should come soon (it is about time).

@roddhjav roddhjav merged commit f0416de into roddhjav:master Jan 25, 2024
@davidandreoletti
Copy link
Copy Markdown
Contributor Author

davidandreoletti commented Feb 14, 2024

Next release should come soon (it is about time).

@roddhjav At this point, a production system I maintain needs a new pass-import official release with the fixes I contributed to/merged ~3weeks ago.

Is that something that can be done within this week/next week ?

@roddhjav
Copy link
Copy Markdown
Owner

That is now done.

@davidandreoletti
Copy link
Copy Markdown
Contributor Author

Fantastic! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants