Move CoqDoc backends to first class modules.#122
Closed
ejgallego wants to merge 1 commit intorocq-prover:v8.5from
Closed
Move CoqDoc backends to first class modules.#122ejgallego wants to merge 1 commit intorocq-prover:v8.5from
ejgallego wants to merge 1 commit intorocq-prover:v8.5from
Conversation
60104c2 to
c411b60
Compare
Closed
Coqdoc output backend selection is implemented using an `if then else` construction; thus adding new backends is a bit painful. Ocaml 3.12 has first class modules which allow to have a more convenient runtime backend selection. The patch is relatively straightforward; tested under Ocaml 3.12.1 & 4.03. Move CoqDoc backends to first class modules.
c411b60 to
337d3ca
Compare
Contributor
Author
|
Closing as I'm gonna consolidate the Coqdoc PR in one. |
Closed
jfehrle
pushed a commit
to jfehrle/coq
that referenced
this pull request
Dec 19, 2022
Make name universe polymorphic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new backends to CoqDoc is a bit painful due to the lack of runtime module selection.
Fortunately since Ocaml 3.12, first class modules allow to have a cleaner backend selection.
The patch is relatively straightforward; tested under Ocaml 3.12.1 & 4.03.
A follow-up patch (if wanted) would be to split the backends in files.