Refactoring part of #11120 about printing applied global references#11326
Merged
ejgallego merged 6 commits intorocq-prover:masterfrom Feb 2, 2020
Conversation
3 tasks
54bdf8d to
c3f8741
Compare
2 tasks
…otations. This shows a few bugs and even anomalies. See issue rocq-prover#11091. See further commits for some fixes.
Should be semantically equivalent.
Should be semantically equivalent.
c3f8741 to
0fde47c
Compare
ejgallego
approved these changes
Jan 30, 2020
Contributor
ejgallego
left a comment
There was a problem hiding this comment.
Changes look good, sorry for the delay @herbelin ; will merge tomorrow if no further comment arise.
There are some general comments about the structure of code and possible directions, but I think this could be discussed in-person at the CUDW better.
Member
Author
|
Thanks for your support.
Is it about the structure of code in this PR? If yes, I'd prefer to discuss earlier! |
ejgallego
added a commit
that referenced
this pull request
Feb 2, 2020
…obal references Reviewed-by: ejgallego
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kind: refactoring
This contains the main pure-refactoring commits of #11120. It is intended to be w/o any semantic changes. It also adds a test-file summarizing the current inconsistencies between parsing and printing wrt inheritance of implicit arguments and scopes in notations bound to applied global references.