Skip to content

Create CONTRIBUTING.md file#10

Merged
SkalskiP merged 1 commit into
mainfrom
add-contributing
Feb 6, 2023
Merged

Create CONTRIBUTING.md file#10
SkalskiP merged 1 commit into
mainfrom
add-contributing

Conversation

@capjamesg

Copy link
Copy Markdown
Contributor

Description

This PR introduces a new CONTRIBUTING.md file that outlines contribution guidelines for this project.

Type of change

  • Documentation changes

How has this change been tested, please provide a testcase or example of how you tested the change?

N/A

Any specific deployment considerations

N/A

Docs

N/A

@capjamesg capjamesg added the documentation Improvements or additions to documentation label Feb 1, 2023
@capjamesg capjamesg requested a review from SkalskiP February 1, 2023 16:27
@capjamesg capjamesg self-assigned this Feb 1, 2023
@SkalskiP SkalskiP merged commit dfb757b into main Feb 6, 2023
@capjamesg capjamesg deleted the add-contributing branch July 5, 2023 08:49
Borda added a commit that referenced this pull request Apr 14, 2026
[resolve #10] /review finding by qa-specialist (report: .temp/output-review-from-inference-rle-mask-2026-04-14.md):
"No test covers DetectionDataset.from_coco with compressed RLE iscrowd annotations..."

---
Co-authored-by: Claude Code <noreply@anthropic.com>
Borda added a commit to shaun0927/supervision that referenced this pull request Apr 17, 2026
…oader

Confirm that 'train/image.jpg' passes all three guards without error,
guarding against false-positive regressions where valid nested paths
are accidentally rejected.

[resolve roboflow#10] /review finding by qa-specialist (report: .temp/output-review-fix-coco-loader-path-containment-2026-04-17.md):
"No positive test for valid nested file_name — false-positive regression undetectable"

---
Co-authored-by: Claude Code <noreply@anthropic.com>
Borda added a commit that referenced this pull request Apr 22, 2026
- Rename TestResize → TestCompactMaskResize for naming consistency with
  other test classes in test_compact_mask.py
- Add test_join_true_true_junction_no_zero_run targeting the True/True
  boundary merge introduced in the prior fix
- Move _PARALLEL_THRESHOLD to module level alongside _L3_DENSITY_THRESHOLD
- Cap ThreadPoolExecutor max_workers=min(n, os.cpu_count() or 4) to avoid
  thread contention in library code
- Document identity-resize shallow-copy semantics in inline comment

[resolve #3] @Copilot (gh): "TestResize is a very generic class name..."
[resolve #9] /review by sw-engineer: "_PARALLEL_THRESHOLD constant buried in method body"
[resolve #10] /review by sw-engineer: "ThreadPoolExecutor() with no max_workers argument"
[resolve #11] /review by sw-engineer: "identity resize does shallow copy of list(self._rles)"
[resolve #12] /review by qa-specialist: "_rle_join_cols has no test for True/True junction"

---
Co-authored-by: Claude Code <noreply@anthropic.com>
Borda added a commit to madhavcodez/supervision that referenced this pull request May 22, 2026
…etections

Three additions:
- Assert cv2.imwrite return value in _tiny_detection_dataset helper so
  codec failures produce explicit errors rather than cryptic downstream ones
- Fix _tiny_detection_dataset xyxy shape for dets_per_image=0 (was (0,),
  now (0,4) via reshape — required by Detections validator)
- test_save_coco_annotations_annotation_image_id_references_correct_image:
  verifies every annotation.image_id references a known image id after
  chaining with a non-default starting_image_id
- test_save_coco_annotations_zero_annotation_images: pins behaviour for
  images with zero detections — image ids advance, annotation list empty

[resolve roboflow#6] /review finding by foundry:qa-specialist (report: .reports/review/2026-05-22T18-44-11Z/review-report.md):
[resolve roboflow#7] /review finding by foundry:qa-specialist (report: .reports/review/2026-05-22T18-44-11Z/review-report.md):
[resolve roboflow#10] @Copilot (gh comment #3290385653):

---
Co-authored-by: Claude Code <noreply@anthropic.com>
Borda added a commit to kounelisagis/supervision that referenced this pull request Jun 8, 2026
- [resolve roboflow#4] test_with_nmm_falls_back_to_box_nmm_without_obb_data: regression
  guard that non-OBB Detections still collapse via box NMM path.
  Challenge: evidence=VALID suggestion=VALID resolution=as-suggested
- [resolve roboflow#10] boundary tests: empty/single, iou_threshold=0.0/1.0, IOS metric
  end-to-end NMS, and OBB NMM empty/single — converted threshold test to
  parametrize(expected_keep) removing if-branch from test body.
  Challenge: evidence=VALID suggestion=VALID resolution=as-suggested
- Added test_with_nmm_obb_merged_xyxy_matches_winner_aabb verifying the
  item roboflow#3 contract: merged xyxy == winner's AABB, not union of all members.

[resolve group] PR roboflow#2303 — items 4, 10

---
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants