Default HTTP port in config example #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houqp
pushed a commit
to roapi/roapi
that referenced
this pull request
Jan 22, 2025
Update the example HTTP port in the configuration sample to match other query/cli examples in the README file. All examples used port `8080`, but we have `8084` in the configuration example. This is not a major issue, but if the ports are the same everywhere, it will be easier for new users to run the project and test the examples. The main documentation has also been updated in [this PR](roapi/docs#21).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the example HTTP port in the configuration sample to match other query/cli examples in the README file.
All examples used port
8080, but we have8084in the configuration example. This is not a major issue, but if the ports are the same everywhere, it will be easier for new users to run the project and test the examples.