Skip to content

Make sure that RNP supports all features which should be supported.#1903

Merged
ronaldtse merged 3 commits intornpgp:masterfrom
ni4:ni4-1901-fix-ENABLE_IDEA
Sep 20, 2022
Merged

Make sure that RNP supports all features which should be supported.#1903
ronaldtse merged 3 commits intornpgp:masterfrom
ni4:ni4-1901-fix-ENABLE_IDEA

Conversation

@ni4
Copy link
Copy Markdown
Contributor

@ni4 ni4 commented Sep 14, 2022

This PR fixes issues which accidentally got into v0.16.1 release:

@ni4 ni4 force-pushed the ni4-1901-fix-ENABLE_IDEA branch from 07d760b to e4df9bb Compare September 14, 2022 12:00
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1903 (facd3fa) into master (c0f4c5e) will increase coverage by 0.06%.
The diff coverage is 53.33%.

@@            Coverage Diff             @@
##           master    #1903      +/-   ##
==========================================
+ Coverage   81.70%   81.77%   +0.06%     
==========================================
  Files         140      140              
  Lines       28944    28976      +32     
==========================================
+ Hits        23648    23694      +46     
+ Misses       5296     5282      -14     
Impacted Files Coverage Δ
src/lib/crypto/symmetric.cpp 84.56% <ø> (+0.77%) ⬆️
src/librepgp/stream-dump.cpp 78.48% <ø> (ø)
src/tests/ffi.cpp 86.29% <ø> (ø)
src/tests/key-validate.cpp 99.55% <ø> (+<0.01%) ⬆️
src/tests/load-pgp.cpp 96.64% <ø> (-0.54%) ⬇️
src/tests/ffi-key-prop.cpp 89.49% <30.00%> (-1.94%) ⬇️
src/tests/cipher.cpp 93.72% <100.00%> (+0.08%) ⬆️
src/tests/streams.cpp 93.27% <100.00%> (+0.02%) ⬆️
src/lib/crypto/cipher_botan.cpp 77.52% <0.00%> (-0.50%) ⬇️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ni4 ni4 force-pushed the ni4-1901-fix-ENABLE_IDEA branch 17 times, most recently from fda10a9 to f24195e Compare September 19, 2022 09:25
@ni4 ni4 force-pushed the ni4-1901-fix-ENABLE_IDEA branch from f24195e to facd3fa Compare September 19, 2022 09:47
@ni4 ni4 added this to the v0.16.2 milestone Sep 19, 2022
@ni4
Copy link
Copy Markdown
Contributor Author

ni4 commented Sep 19, 2022

The codecov/path failure could be ignored.

Copy link
Copy Markdown
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ni4 !

@ronaldtse
Copy link
Copy Markdown
Contributor

I wonder if some of the bash scripts can be cleaner but it's not really a problem right now.

@ronaldtse
Copy link
Copy Markdown
Contributor

Merging with two approvals.

@ronaldtse ronaldtse merged commit 4c00072 into rnpgp:master Sep 20, 2022
@ni4 ni4 deleted the ni4-1901-fix-ENABLE_IDEA branch September 22, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ENABLE_BRAINPOOL not working with CRYPTO_BACKEND=openssl ENABLE_IDEA not working

3 participants