Skip to content

Commit facd3fa

Browse files
committed
Update CI with checks for disabled IDEA, and remove redundant checks.
1 parent b379d2c commit facd3fa

2 files changed

Lines changed: 19 additions & 26 deletions

File tree

.github/workflows/centos8-ossl.yml

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -53,39 +53,16 @@ jobs:
5353
matrix:
5454
env:
5555
- BUILD_MODE: normal
56-
RNP_TESTS: rnp_tests
5756
CC: gcc
5857
CXX: g++
59-
- BUILD_MODE: sanitize
60-
RNP_TESTS: rnp_tests
61-
CC: gcc
62-
CXX: g++
63-
- BUILD_MODE: normal
64-
RNP_TESTS: cli_tests
65-
CC: gcc
66-
CXX: g++
67-
- BUILD_MODE: sanitize
68-
RNP_TESTS: cli_tests
69-
CC: gcc
70-
CXX: g++
71-
- BUILD_MODE: normal
72-
RNP_TESTS: rnp_tests
73-
CC: clang
74-
CXX: clang++
75-
- BUILD_MODE: sanitize
76-
RNP_TESTS: rnp_tests
77-
CC: clang
78-
CXX: clang++
7958
- BUILD_MODE: normal
80-
RNP_TESTS: cli_tests
8159
CC: clang
8260
CXX: clang++
8361
- BUILD_MODE: sanitize
84-
RNP_TESTS: cli_tests
8562
CC: clang
8663
CXX: clang++
8764
env: ${{ matrix.env }}
88-
name: centos:stream8 OpenSSL [test type ${{ matrix.env.RNP_TESTS }}; mode ${{ matrix.env.BUILD_MODE }}; CC ${{ matrix.env.CC }}; GnuPG ${{ matrix.env.GPG_VERSION }}]
65+
name: centos:stream8 OpenSSL [test mode ${{ matrix.env.BUILD_MODE }}; CC ${{ matrix.env.CC }}]
8966
steps:
9067
- run: |
9168
yum -y install git
@@ -107,7 +84,7 @@ jobs:
10784
uses: actions/cache@v2
10885
with:
10986
path: ${{ env.CACHE_DIR }}
110-
key: ${{ github.workflow }}-${{ runner.os }}-${{ matrix.env.BUILD_MODE }}-${{ matrix.env.CC }}-gpg-${{ matrix.env.GPG_VERSION }}-${{ hashFiles('ci/**') }}-${{ hashFiles('.github/workflows/**') }}
87+
key: ${{ github.workflow }}-${{ runner.os }}-${{ matrix.env.BUILD_MODE }}-${{ matrix.env.CC }}-${{ hashFiles('ci/**') }}-${{ hashFiles('.github/workflows/**') }}
11188
- name: Build cache
11289
if: steps.cache.outputs.cache-hit != 'true'
11390
run: |

.github/workflows/centos9-ossl.yml

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,25 @@ jobs:
5555
- BUILD_MODE: normal
5656
CC: gcc
5757
CXX: g++
58+
ENABLE_IDEA: On
59+
- BUILD_MODE: normal
60+
CC: gcc
61+
CXX: g++
62+
ENABLE_IDEA: Off
5863
- BUILD_MODE: normal
5964
CC: clang
6065
CXX: clang++
66+
ENABLE_IDEA: On
6167
# Sanitize is only tested with the clang compiler
6268
# see env-common.inc.sh
6369
- BUILD_MODE: sanitize
6470
CC: clang
6571
CXX: clang++
72+
ENABLE_IDEA: On
73+
- BUILD_MODE: sanitize
74+
CC: clang
75+
CXX: clang++
76+
ENABLE_IDEA: Off
6677
env: ${{ matrix.env }}
6778
name: centos:stream9 OpenSSL [mode ${{ matrix.env.BUILD_MODE }}; CC ${{ matrix.env.CC }};]
6879
steps:
@@ -99,7 +110,7 @@ jobs:
99110
/home/rnpuser/local-installs/rnp-install/bin/rnp --version > rnp-version
100111
# Make sure that we support all features which should be supported
101112
supported=( RSA ELGAMAL DSA ECDH ECDSA EDDSA \
102-
IDEA TRIPLEDES CAST5 BLOWFISH AES128 AES192 AES256 CAMELLIA128 CAMELLIA192 CAMELLIA256 \
113+
TRIPLEDES CAST5 BLOWFISH AES128 AES192 AES256 CAMELLIA128 CAMELLIA192 CAMELLIA256 \
103114
MD5 SHA1 RIPEMD160 SHA256 SHA384 SHA512 SHA224 SHA3-256 SHA3-512 \
104115
ZIP ZLIB BZip2 \
105116
"NIST P-256" "NIST P-384" "NIST P-521" Ed25519 Curve25519 secp256k1 )
@@ -108,6 +119,11 @@ jobs:
108119
bp=( brainpoolP256r1 brainpoolP384r1 brainpoolP512r1 )
109120
# SM2
110121
unsupported+=("${sm2[@]}")
122+
if [[ "$ENABLE_IDEA" == "On" ]] ;then
123+
supported+=(IDEA)
124+
else
125+
unsupported+=(IDEA)
126+
fi
111127
unsupported+=("${bp[@]}")
112128
for feature in "${supported[@]}"
113129
do

0 commit comments

Comments
 (0)