Add some type annotations.#1
Merged
rjzamora merged 4 commits intorjzamora:initial-collection-operationfrom May 27, 2022
Merged
Conversation
ian-r-rose
commented
May 26, 2022
dask/dataframe/operation.py
Outdated
| from typing import Any, Callable, Hashable | ||
| from typing import Any, Callable | ||
|
|
||
| from typing_extensions import TypeAlias |
Author
There was a problem hiding this comment.
Would require adding this to the requirements, but it's already added in distributed, so I wouldn't be too worried
| "CollectionOperationType", bound="CollectionOperation" | ||
| ) | ||
|
|
||
| @dataclass(frozen=True) |
Author
There was a problem hiding this comment.
I saw no reason to make these dataclasses instead of an abstract interface
added 2 commits
May 26, 2022 16:58
rjzamora
approved these changes
May 27, 2022
rjzamora
reviewed
May 27, 2022
Codecov Report
@@ Coverage Diff @@
## initial-collection-operation #1 +/- ##
================================================================
- Coverage 92.14% 89.95% -2.19%
================================================================
Files 120 120
Lines 28181 28163 -18
================================================================
- Hits 25966 25333 -633
- Misses 2215 2830 +615
Continue to review full report at Codecov.
|
rjzamora
added a commit
that referenced
this pull request
Jan 9, 2025
Updates `ReadParquet` to use metadata-parsing and IO logic from `dask.dataframe.io.parquet`. Requires dask#9637 (only because my environment was using that PR when I put this together).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick hit on some annotations that I find helpful, as per dask#9119 (comment) :)